From 1443936e967d4a0a49acb8756e3f808dc3628318 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Wed, 31 Oct 2018 16:33:46 +0100 Subject: [PATCH] [gdb/testsuite] get_valueof: Don't output value in test name The get_valueof outputs the value it has read as part of the test name. This causes test names to vary from run to run, and adds some noise when diffing test results. e.g.: -PASS: gdb.guile/scm-ports.exp: buffered: get valueof "$sp" (140737488343920) +PASS: gdb.guile/scm-ports.exp: buffered: get valueof "$sp" (140737488343968) -PASS: gdb.guile/scm-ports.exp: unbuffered: get valueof "$sp" (140737488343920) +PASS: gdb.guile/scm-ports.exp: unbuffered: get valueof "$sp" (140737488343968) This patch removes that, since it's probably not very useful. Tested on x86_64-linux. 2018-10-31 Tom de Vries * lib/gdb.exp (get_valueof): Don't output read value in test name. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/lib/gdb.exp | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 8fa6b0d674f..2f0085b6e09 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2018-10-31 Tom de Vries + + * lib/gdb.exp (get_valueof): Don't output read value in test name. + 2018-10-31 Andrew Burgess * gdb.dwarf2/void-type.c: New file. diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index b4cf80e38a0..5a5713b1148 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -5636,7 +5636,7 @@ proc get_valueof { fmt exp default {test ""} } { gdb_test_multiple "print${fmt} ${exp}" "$test" { -re "\\$\[0-9\]* = (\[^\r\n\]*)\[\r\n\]*$gdb_prompt $" { set val $expect_out(1,string) - pass "$test ($val)" + pass "$test" } timeout { fail "$test (timeout)" -- 2.30.2