From 1448fa32275a8686debba9323308841480c33fc7 Mon Sep 17 00:00:00 2001 From: Kaz Kojima Date: Thu, 28 Nov 2002 08:37:15 +0000 Subject: [PATCH] * elf32-sh.c (sh_elf_relocate_section): Don't complain about unresolved debugging relocs in dynamic applications. * elf64-sh64.c (sh_elf64_relocate_section): Likewise. * ld-sh/refdbg-0-dso.d: New test. * ld-sh/refdbg-1.d: Likewise. * ld-sh/refdbg.s: Likewise. * ld-sh/refdbglib.s: Likewise. --- bfd/ChangeLog | 6 ++++++ bfd/elf32-sh.c | 7 +++++++ bfd/elf64-sh64.c | 9 ++++++++- ld/testsuite/ChangeLog | 7 +++++++ ld/testsuite/ld-sh/refdbg-0-dso.d | 9 +++++++++ ld/testsuite/ld-sh/refdbg-1.d | 10 ++++++++++ ld/testsuite/ld-sh/refdbg.s | 11 +++++++++++ ld/testsuite/ld-sh/refdbglib.s | 8 ++++++++ 8 files changed, 66 insertions(+), 1 deletion(-) create mode 100644 ld/testsuite/ld-sh/refdbg-0-dso.d create mode 100644 ld/testsuite/ld-sh/refdbg-1.d create mode 100644 ld/testsuite/ld-sh/refdbg.s create mode 100644 ld/testsuite/ld-sh/refdbglib.s diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 1823e3a8379..f0b8dc68352 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2002-11-28 Kaz Kojima + + * elf32-sh.c (sh_elf_relocate_section): Don't complain about + unresolved debugging relocs in dynamic applications. + * elf64-sh64.c (sh_elf64_relocate_section): Likewise. + 2002-11-26 Alan Modra * elf-eh-frame.c (ENSURE_NO_RELOCS): Disregard R_*_NONE relocs. diff --git a/bfd/elf32-sh.c b/bfd/elf32-sh.c index f52245bcc34..c7c078ceaf4 100644 --- a/bfd/elf32-sh.c +++ b/bfd/elf32-sh.c @@ -4753,6 +4753,13 @@ sh_elf_relocate_section (output_bfd, info, input_bfd, input_section, || ((input_section->flags & SEC_DEBUGGING) != 0 && (h->elf_link_hash_flags & ELF_LINK_HASH_DEF_DYNAMIC) != 0))) + /* Dynamic relocs are not propagated for SEC_DEBUGGING + sections because such sections are not SEC_ALLOC and + thus ld.so will not process them. */ + || (sec->output_section == NULL + && ((input_section->flags & SEC_DEBUGGING) != 0 + && (h->elf_link_hash_flags + & ELF_LINK_HASH_DEF_DYNAMIC) != 0)) || (sec->output_section == NULL && (sh_elf_hash_entry (h)->tls_type == GOT_TLS_IE || sh_elf_hash_entry (h)->tls_type == GOT_TLS_GD))) diff --git a/bfd/elf64-sh64.c b/bfd/elf64-sh64.c index da02505d5c5..590c13369cd 100644 --- a/bfd/elf64-sh64.c +++ b/bfd/elf64-sh64.c @@ -1680,7 +1680,14 @@ sh_elf64_relocate_section (output_bfd, info, input_bfd, input_section, sections against symbols defined externally in shared libraries. We can't do anything with them here. */ - || (input_section->flags & SEC_DEBUGGING) != 0))) + || (input_section->flags & SEC_DEBUGGING) != 0)) + /* Dynamic relocs are not propagated for SEC_DEBUGGING + sections because such sections are not SEC_ALLOC and + thus ld.so will not process them. */ + || (sec->output_section == NULL + && ((input_section->flags & SEC_DEBUGGING) != 0 + && (h->elf_link_hash_flags + & ELF_LINK_HASH_DEF_DYNAMIC) != 0))) relocation = 0; else if (sec->output_section == NULL) { diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog index 4a56a90451e..27a09ff8e43 100644 --- a/ld/testsuite/ChangeLog +++ b/ld/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2002-11-28 Kaz Kojima + + * ld-sh/refdbg-0-dso.d: New test. + * ld-sh/refdbg-1.d: Likewise. + * ld-sh/refdbg.s: Likewise. + * ld-sh/refdbglib.s: Likewise. + 2002-11-22 Alan Modra * ld-elf/elf.exp: Remove sec64k test. diff --git a/ld/testsuite/ld-sh/refdbg-0-dso.d b/ld/testsuite/ld-sh/refdbg-0-dso.d new file mode 100644 index 00000000000..c38fe3e91bf --- /dev/null +++ b/ld/testsuite/ld-sh/refdbg-0-dso.d @@ -0,0 +1,9 @@ +#source: refdbglib.s +#as: -little +#ld: -shared -EL +#objdump: -drj.text +#target: sh*-*-linux* sh*-*-netbsd* + +.*: +file format elf32-sh.* + +#pass diff --git a/ld/testsuite/ld-sh/refdbg-1.d b/ld/testsuite/ld-sh/refdbg-1.d new file mode 100644 index 00000000000..461788e2ea5 --- /dev/null +++ b/ld/testsuite/ld-sh/refdbg-1.d @@ -0,0 +1,10 @@ +#source: refdbg.s +#as: -little +#ld: -EL tmpdir/refdbg-0-dso.so +#objdump: -sj.debug_info +#target: sh*-*-linux* sh*-*-netbsd* + +.*: +file format elf32-sh.* + +Contents of section \.debug_info: + 0+0 0+0 +.* diff --git a/ld/testsuite/ld-sh/refdbg.s b/ld/testsuite/ld-sh/refdbg.s new file mode 100644 index 00000000000..129d6896f41 --- /dev/null +++ b/ld/testsuite/ld-sh/refdbg.s @@ -0,0 +1,11 @@ + .text + .align 2 + .globl _start + .type _start,@function +_start: + rts + nop + + .comm foo,4,4 + .section .debug_info,"",@progbits + .ualong foo diff --git a/ld/testsuite/ld-sh/refdbglib.s b/ld/testsuite/ld-sh/refdbglib.s new file mode 100644 index 00000000000..31244acd9ed --- /dev/null +++ b/ld/testsuite/ld-sh/refdbglib.s @@ -0,0 +1,8 @@ + .text + .global foo + .data + .align 2 + .type foo, @object + .size foo, 4 +foo: + .long 1 -- 2.30.2