From 16eba92873ed99eaa5bfb66e7b5f72768ffe503c Mon Sep 17 00:00:00 2001 From: Jason Merrill Date: Fri, 16 Jan 2009 00:04:26 -0500 Subject: [PATCH] re PR c++/38850 (Cannot find inline friend function in template class when called from within a template function) PR c++/38850 * pt.c (tsubst_copy_and_build): Tell finish_call_expr to accept hidden friends. From-SVN: r143422 --- gcc/cp/ChangeLog | 6 +++++ gcc/cp/pt.c | 5 ++++- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/g++.dg/template/koenig6.C | 29 +++++++++++++++++++++++++ 4 files changed, 44 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/template/koenig6.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 57ae7570d5f..306867419d8 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2009-01-15 Jason Merrill + + PR c++/38850 + * pt.c (tsubst_copy_and_build): Tell finish_call_expr to + accept hidden friends. + 2009-01-15 Andrew Pinski PR C++/29388 diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c index 0618fe24328..0378d39be12 100644 --- a/gcc/cp/pt.c +++ b/gcc/cp/pt.c @@ -11400,9 +11400,12 @@ tsubst_copy_and_build (tree t, /*fn_p=*/NULL, complain)); } + /* Pass true for koenig_p so that build_new_function_call will + allow hidden friends found by arg-dependent lookup at template + parsing time. */ return finish_call_expr (function, call_args, /*disallow_virtual=*/qualified_p, - koenig_p, + /*koenig_p*/true, complain); } diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 3e46d1fc971..0a4383f755b 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2009-01-15 Jason Merrill + + PR c++/38850 + * g++.dg/template/koenig6.C: New test. + 2009-01-15 Andrew Pinski PR C++/29388 diff --git a/gcc/testsuite/g++.dg/template/koenig6.C b/gcc/testsuite/g++.dg/template/koenig6.C new file mode 100644 index 00000000000..8f93a653a7b --- /dev/null +++ b/gcc/testsuite/g++.dg/template/koenig6.C @@ -0,0 +1,29 @@ +// PR c++/38850 + +template +class Vector2 { + private: + VType c_[2]; + public: + typedef Vector2 Self; + + Vector2(const VType x, const VType y) { + c_[0] = x; + c_[1] = y; + } + + friend inline Self Max(const Self &v1, const Self &v2) { + return Self(v1.c_[0], v1.c_[1]); + } +}; + +template +Vector2 foo(T x) { + Vector2 y(0,0); + return Max(y, y); +} + +int main() { + foo(3); + return 0; +} -- 2.30.2