From 1760c24b4bcf028477404e283f5768f2b6f25123 Mon Sep 17 00:00:00 2001 From: Francisco Jerez Date: Tue, 17 May 2016 16:54:16 -0700 Subject: [PATCH] i965/fs: No need to unzip SIMD-periodic sources during SIMD lowering. If the source value is going to the same for all SIMD-lowered chunks of the instruction there should be no need to unzip the value into multiple temporary registers one for each lowered chunk. As a side effect this fixes SIMD lowering of instructions with a vector immediate source. In the long term it *might* still be worth fixing offset() to handle vector immediates correctly though, this should be good enough for the moment. Reviewed-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index bb2caa54e17..bb11be157a2 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp @@ -4767,7 +4767,7 @@ fs_visitor::lower_simd_width() for (unsigned j = 0; j < inst->sources; j++) { if (inst->src[j].file != BAD_FILE && - !is_uniform(inst->src[j])) { + !is_periodic(inst->src[j], lower_width)) { /* Get the i-th copy_width-wide chunk of the source. */ const fs_builder cbld = lbld.group(copy_width, 0); const fs_reg src = offset(inst->src[j], cbld, i); -- 2.30.2