From 17eb1df7b8af800f03c5b1f35fdf4292abe32ea1 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Mon, 9 Sep 2013 15:36:59 -0700 Subject: [PATCH] i965/vec4: Simplify the computation of coord_mask and zero_mask. We can easily compute these without loops, resulting in simpler and shorter code. Signed-off-by: Kenneth Graunke Suggested-by: Ian Romanick Reviewed-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index 28dc313e431..a51b61baf03 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp @@ -2221,13 +2221,10 @@ vec4_visitor::visit(ir_texture *ir) int writemask = brw->gen == 4 ? WRITEMASK_W : WRITEMASK_X; emit(MOV(dst_reg(MRF, param_base, lod_type, writemask), lod)); } else { - int i, coord_mask = 0, zero_mask = 0; /* Load the coordinate */ /* FINISHME: gl_clamp_mask and saturate */ - for (i = 0; i < ir->coordinate->type->vector_elements; i++) - coord_mask |= (1 << i); - for (; i < 4; i++) - zero_mask |= (1 << i); + int coord_mask = (1 << ir->coordinate->type->vector_elements) - 1; + int zero_mask = 0xf & ~coord_mask; if (ir->offset && ir->op == ir_txf) { /* It appears that the ld instruction used for txf does its -- 2.30.2