From 18f8200a994440faa9fb9e80e99e8140ea912993 Mon Sep 17 00:00:00 2001 From: Jason Ekstrand Date: Fri, 11 May 2018 15:02:13 -0700 Subject: [PATCH] intel/blorp: Use linear formats for CCS_E clear colors in copies It's clear that the original code meant to do this and there is even a 10-line comment explaining why. Originally, we had a simple function for packing the clear colors which was unaware of sRGB. However, in a6b66a7b26ae1, when we started using ISL to do the packing, the wrong format was used. Fixes: a6b66a7b26 "intel/blorp: Use ISL instead of bitcast_color..." Reviewed-by: Topi Pohjolainen --- src/intel/blorp/blorp_blit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index e825862d71a..26bf4426c0b 100644 --- a/src/intel/blorp/blorp_blit.c +++ b/src/intel/blorp/blorp_blit.c @@ -2562,7 +2562,7 @@ blorp_copy(struct blorp_batch *batch, params.src.view.format)); uint32_t packed[4]; isl_color_value_pack(¶ms.src.clear_color, - params.src.surf.format, packed); + linear_src_format, packed); isl_color_value_unpack(¶ms.src.clear_color, params.src.view.format, packed); } @@ -2576,7 +2576,7 @@ blorp_copy(struct blorp_batch *batch, params.dst.view.format)); uint32_t packed[4]; isl_color_value_pack(¶ms.dst.clear_color, - params.dst.surf.format, packed); + linear_dst_format, packed); isl_color_value_unpack(¶ms.dst.clear_color, params.dst.view.format, packed); } -- 2.30.2