From 193cb67a84c1725382f62a2f3aa60564d275c2f8 Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Thu, 31 Mar 2016 12:05:31 +0200 Subject: [PATCH] i965/fs: recognize writes with a subreg_offset > 0 as partial Usually, writes to a subreg_offset > 0 would also have a stride > 1 and we would recognize them as partial, however, there is one case where this does not happen, that is when we generate code for 64-bit imemdiates in gen7, where we produce something like this: mov(8) vgrf10:UD, mov(8) vgrf10+0.4:UD, and then we use the result with a stride of 0, as in: mov(8) vgrf13:DF, vgrf10<0>:DF Although we could try to avoid this issue by producing different code for this by using writes with a stride of 2, that runs into other problems affecting gen7 and the fact is that any instruction that writes to a subreg_offset > 0 is a partial write so we should really recognize them as such. Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index dcbb4bd8b84..dd2685dfbb8 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp @@ -700,7 +700,8 @@ fs_inst::is_partial_write() const { return ((this->predicate && this->opcode != BRW_OPCODE_SEL) || (this->exec_size * type_sz(this->dst.type)) < 32 || - !this->dst.is_contiguous()); + !this->dst.is_contiguous() || + this->dst.subreg_offset > 0); } unsigned -- 2.30.2