From 1a631bd79bdcf2d66d845f79758e16e3ec9d7a7f Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Wed, 1 May 2019 20:16:56 -0700 Subject: [PATCH] mem: Use a const T & in write<> to avoid an unnecessary copy. If the type T is complex/large, the it makes sense to access it in place and not copy it and then not modify it. Change-Id: Idd24be4fbba636375637ff72b1ba5ee32eb76215 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/18573 Tested-by: kokoro Reviewed-by: Jason Lowe-Power Reviewed-by: Andreas Sandberg Maintainer: Andreas Sandberg --- src/mem/port_proxy.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mem/port_proxy.hh b/src/mem/port_proxy.hh index 096f82664..469273f85 100644 --- a/src/mem/port_proxy.hh +++ b/src/mem/port_proxy.hh @@ -195,7 +195,7 @@ class PortProxy * Write object T to address. Writes sizeof(T) bytes. */ template - void write(Addr address, T data) const; + void write(Addr address, const T &data) const; /** * Read sizeof(T) bytes from address and return as object T. @@ -256,7 +256,7 @@ PortProxy::read(Addr address) const template void -PortProxy::write(Addr address, T data) const +PortProxy::write(Addr address, const T &data) const { writeBlob(address, &data, sizeof(T)); } -- 2.30.2