From 1b592d30c51696eeeadca7a55b603c543dfdc3cf Mon Sep 17 00:00:00 2001 From: =?utf8?q?Nicolai=20H=C3=A4hnle?= Date: Tue, 10 Oct 2017 13:58:46 +0200 Subject: [PATCH] u_threaded_context: fix a memory leak MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The uploaders can own transfers which need to be unmapped. Destroy them before the final sync (they're not used from the driver thread anyway) so that the transfer_unmap call is processed by the driver. Reviewed-by: Marek Olšák --- src/gallium/auxiliary/util/u_threaded_context.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/gallium/auxiliary/util/u_threaded_context.c b/src/gallium/auxiliary/util/u_threaded_context.c index 043d4e67df1..7e28b87a7ff 100644 --- a/src/gallium/auxiliary/util/u_threaded_context.c +++ b/src/gallium/auxiliary/util/u_threaded_context.c @@ -2233,6 +2233,13 @@ tc_destroy(struct pipe_context *_pipe) struct threaded_context *tc = threaded_context(_pipe); struct pipe_context *pipe = tc->pipe; + if (tc->base.const_uploader && + tc->base.stream_uploader != tc->base.const_uploader) + u_upload_destroy(tc->base.const_uploader); + + if (tc->base.stream_uploader) + u_upload_destroy(tc->base.stream_uploader); + tc_sync(tc); if (util_queue_is_initialized(&tc->queue)) { @@ -2242,14 +2249,8 @@ tc_destroy(struct pipe_context *_pipe) util_queue_fence_destroy(&tc->batch_slots[i].fence); } - if (tc->base.const_uploader && - tc->base.stream_uploader != tc->base.const_uploader) - u_upload_destroy(tc->base.const_uploader); - - if (tc->base.stream_uploader) - u_upload_destroy(tc->base.stream_uploader); - slab_destroy_child(&tc->pool_transfers); + assert(tc->batch_slots[tc->next].num_total_call_slots == 0); pipe->destroy(pipe); os_free_aligned(tc); } -- 2.30.2