From 1b674de05347bf855c4e06656cd8276715ee0092 Mon Sep 17 00:00:00 2001 From: Richard Guenther Date: Thu, 8 May 2008 08:20:45 +0000 Subject: [PATCH] re PR middle-end/36154 (internal compiler error: in get_constraint_for_component_ref, at tree-ssa-structalias.c:2727) 2008-05-08 Richard Guenther PR middle-end/36154 * tree-ssa-structalias.c (push_fields_onto_fieldstack): Make sure to create a representative for trailing arrays for PTA. * gcc.c-torture/compile/pr36154.c: New testcase. From-SVN: r135071 --- gcc/ChangeLog | 6 ++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.c-torture/compile/pr36154.c | 11 +++++++++++ gcc/tree-ssa-structalias.c | 12 ++++++++---- 4 files changed, 30 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/gcc.c-torture/compile/pr36154.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index bdc484612dd..1121be1a9e0 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2008-05-08 Richard Guenther + + PR middle-end/36154 + * tree-ssa-structalias.c (push_fields_onto_fieldstack): Make + sure to create a representative for trailing arrays for PTA. + 2008-05-08 Richard Guenther PR middle-end/36172 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 68626fdf2f1..2b137fa9988 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2008-05-08 Richard Guenther + + PR middle-end/36154 + * gcc.c-torture/compile/pr36154.c: New testcase. + 2008-05-08 Richard Guenther PR middle-end/36172 diff --git a/gcc/testsuite/gcc.c-torture/compile/pr36154.c b/gcc/testsuite/gcc.c-torture/compile/pr36154.c new file mode 100644 index 00000000000..ae3eb83fa11 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/compile/pr36154.c @@ -0,0 +1,11 @@ +struct eth_test_pkt { + unsigned short len; + unsigned short ctr; + unsigned char packet[]; +} __attribute__ ((packed)); +struct eth_test_pkt pkt_unaligned = { .packet = { 0xFC } }; +int cmd_unaligned(const void *p) +{ + return memcmp(p, pkt_unaligned.packet, 1); +} + diff --git a/gcc/tree-ssa-structalias.c b/gcc/tree-ssa-structalias.c index ddcf4982690..d58478ebeb2 100644 --- a/gcc/tree-ssa-structalias.c +++ b/gcc/tree-ssa-structalias.c @@ -4160,11 +4160,15 @@ push_fields_onto_fieldstack (tree type, VEC(fieldoff_s,heap) **fieldstack, (DECL_NONADDRESSABLE_P (field) ? addressable_type : TREE_TYPE (field)))) - && DECL_SIZE (field) - && !integer_zerop (DECL_SIZE (field))) - /* Empty structures may have actual size, like in C++. So + && ((DECL_SIZE (field) + && !integer_zerop (DECL_SIZE (field))) + || (!DECL_SIZE (field) + && TREE_CODE (TREE_TYPE (field)) == ARRAY_TYPE))) + /* Empty structures may have actual size, like in C++. So see if we didn't push any subfields and the size is - nonzero, push the field onto the stack */ + nonzero, push the field onto the stack. Trailing flexible + array members also need a representative to be able to + treat taking their address in PTA. */ push = true; if (push) -- 2.30.2