From 1be043a140d516e16930bbc357f5ccb7b98c1db5 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fran=C3=A7ois=20Dumont?= Date: Mon, 16 Oct 2017 05:44:03 +0000 Subject: [PATCH] re PR libstdc++/82558 (V8 JavaScript engine segfaults since r249235) MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit 2017-10-16 François Dumont PR libstdc++/82558 * include/bits/stl_bvector.h (fill): Add iterator offset check. * testsuite/23_containers/vector/bool/82558.cc: New. From-SVN: r253776 --- libstdc++-v3/ChangeLog | 6 ++++ libstdc++-v3/include/bits/stl_bvector.h | 2 +- .../23_containers/vector/bool/82558.cc | 32 +++++++++++++++++++ 3 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 libstdc++-v3/testsuite/23_containers/vector/bool/82558.cc diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 64196884160..9177f044fca 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,3 +1,9 @@ +2017-10-16 François Dumont + + PR libstdc++/82558 + * include/bits/stl_bvector.h (fill): Add iterator offset check. + * testsuite/23_containers/vector/bool/82558.cc: New. + 2017-10-13 Jonathan Wakely PR libstdc++/82522 diff --git a/libstdc++-v3/include/bits/stl_bvector.h b/libstdc++-v3/include/bits/stl_bvector.h index d24e760d01b..ac548846b0e 100644 --- a/libstdc++-v3/include/bits/stl_bvector.h +++ b/libstdc++-v3/include/bits/stl_bvector.h @@ -417,7 +417,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER if (__last._M_offset != 0) __fill_bvector(__last._M_p, 0, __last._M_offset, __x); } - else + else if (__first._M_offset != __last._M_offset) __fill_bvector(__first._M_p, __first._M_offset, __last._M_offset, __x); } diff --git a/libstdc++-v3/testsuite/23_containers/vector/bool/82558.cc b/libstdc++-v3/testsuite/23_containers/vector/bool/82558.cc new file mode 100644 index 00000000000..6362688efb5 --- /dev/null +++ b/libstdc++-v3/testsuite/23_containers/vector/bool/82558.cc @@ -0,0 +1,32 @@ +// Copyright (C) 2017 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +// 23.3.8 class vector + +#include + +// libstdc++/82558 +void test01() +{ + std::vector v; + std::fill(v.begin(), v.begin(), false); +} + +int main() +{ + test01(); +} -- 2.30.2