From 1c9177d9a5c3e06d3344347c8068acfb7d8ecc8b Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Tue, 20 Jan 2015 11:06:28 +1030 Subject: [PATCH] Fix garbage collection of common symbols for powerpc64 I forgot powerpc64 has its own gc_mark_dynamic_ref. PR ld/17615 * elf64-ppc.c (ppc64_elf_gc_mark_dynamic_ref): Don't drop ELF_COMMON_DEF syms. --- bfd/ChangeLog | 6 ++++++ bfd/elf64-ppc.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 06cfacb627f..f81961067d6 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2015-01-20 Alan Modra + + PR ld/17615 + * elf64-ppc.c (ppc64_elf_gc_mark_dynamic_ref): Don't drop + ELF_COMMON_DEF syms. + 2015-01-19 Alan Modra PR ld/17615 diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c index f6a8ccb6e5b..5a1ee505190 100644 --- a/bfd/elf64-ppc.c +++ b/bfd/elf64-ppc.c @@ -6232,7 +6232,7 @@ ppc64_elf_gc_mark_dynamic_ref (struct elf_link_hash_entry *h, void *inf) if ((eh->elf.root.type == bfd_link_hash_defined || eh->elf.root.type == bfd_link_hash_defweak) && (eh->elf.ref_dynamic - || (eh->elf.def_regular + || ((eh->elf.def_regular || ELF_COMMON_DEF_P (&eh->elf)) && ELF_ST_VISIBILITY (eh->elf.other) != STV_INTERNAL && ELF_ST_VISIBILITY (eh->elf.other) != STV_HIDDEN && (!info->executable -- 2.30.2