From 1cf5abb382f9dab7203ae6a8d9f2f4421190d1ff Mon Sep 17 00:00:00 2001 From: Jan Hubicka Date: Sun, 1 Mar 2009 12:02:30 +0100 Subject: [PATCH] re PR debug/39267 (gdb testsuite regressions) PR debug/39267 * tree-inline.c (setup_one_parameter): Do not copy propagate arguments when not optimizing. PR debug/39267 * gcc.dg/debug/dwarf2/inline1.c: New testcase. From-SVN: r144515 --- gcc/ChangeLog | 6 ++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/debug/dwarf2/inline1.c | 18 ++++++++++++++++++ gcc/tree-inline.c | 3 ++- 4 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/debug/dwarf2/inline1.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 1db21e564a6..dba3b12a024 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2009-02-28 Jan Hubicka + + PR debug/39267 + * tree-inline.c (setup_one_parameter): Do not copy propagate + arguments when not optimizing. + 2009-02-28 H.J. Lu PR target/39327 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index aeec72ade59..c6b8017d6c3 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2009-03-01 Jan Hubicka + + PR debug/39267 + * gcc.dg/debug/dwarf2/inline1.c: New testcase. + 2009-03-01 Eric Botcazou * gnat.dg/pack12.adb: New test. diff --git a/gcc/testsuite/gcc.dg/debug/dwarf2/inline1.c b/gcc/testsuite/gcc.dg/debug/dwarf2/inline1.c new file mode 100644 index 00000000000..11c8fad7841 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/dwarf2/inline1.c @@ -0,0 +1,18 @@ +/* { dg-do compile } */ +/* { dg-options "-O0 -gdwarf-2 -dA" } */ +void e(int); +__attribute__ ((always_inline)) inline int +t(int function_parameter) +{ + e(function_parameter); +} + +void test (int function_parameter2) +{ + t(function_parameter2); +} + +/* Verify that we get both function_parameter and function_parameter2 declared + in test. Overall we should have 3 variables with location defined (also + function_parameter in offline copy of t. */ +/* { dg-final { scan-assembler-times " DW_AT_location" 3 } } */ diff --git a/gcc/tree-inline.c b/gcc/tree-inline.c index a7e25fd15c8..65d5b88a9ce 100644 --- a/gcc/tree-inline.c +++ b/gcc/tree-inline.c @@ -2048,6 +2048,7 @@ setup_one_parameter (copy_body_data *id, tree p, tree value, tree fn, We might want to introduce a notion that single SSA_NAME might represent multiple variables for purposes of debugging. */ if (gimple_in_ssa_p (cfun) && rhs && def && is_gimple_reg (p) + && optimize && (TREE_CODE (rhs) == SSA_NAME || is_gimple_min_invariant (rhs)) && !SSA_NAME_OCCURS_IN_ABNORMAL_PHI (def)) @@ -2058,7 +2059,7 @@ setup_one_parameter (copy_body_data *id, tree p, tree value, tree fn, /* If the value of argument is never used, don't care about initializing it. */ - if (gimple_in_ssa_p (cfun) && !def && is_gimple_reg (p)) + if (optimize && gimple_in_ssa_p (cfun) && !def && is_gimple_reg (p)) { gcc_assert (!value || !TREE_SIDE_EFFECTS (value)); return NULL; -- 2.30.2