From 1cfeb45e0bdd58c0de6c57b7ae03667424476882 Mon Sep 17 00:00:00 2001
From: whitequark <cz@m-labs.hk>
Date: Sun, 16 Dec 2018 17:41:11 +0000
Subject: [PATCH] back.rtlil: avoid illegal slices.

Not sure what to do with {} [] on LHS yet--fix Yosys?
---
 nmigen/back/rtlil.py | 37 +++++++++++++++++++++++++++++--------
 1 file changed, 29 insertions(+), 8 deletions(-)

diff --git a/nmigen/back/rtlil.py b/nmigen/back/rtlil.py
index 7f584ff..dada675 100644
--- a/nmigen/back/rtlil.py
+++ b/nmigen/back/rtlil.py
@@ -272,14 +272,6 @@ class _ValueCompiler(xfrm.AbstractValueTransformer):
     def on_ResetSignal(self, value):
         raise NotImplementedError # :nocov:
 
-    def on_Slice(self, value):
-        if value.start == 0 and value.end == len(value.value):
-            return self(value.value)
-        elif value.start + 1 == value.end:
-            return "{} [{}]".format(self(value.value), value.start)
-        else:
-            return "{} [{}:{}]".format(self(value.value), value.end - 1, value.start)
-
     def on_Cat(self, value):
         return "{{ {} }}".format(" ".join(reversed([self(o) for o in value.operands])))
 
@@ -410,6 +402,21 @@ class _RHSValueCompiler(_ValueCompiler):
         else:
             raise TypeError # :nocov:
 
+    def on_Slice(self, value):
+        if value.start == 0 and value.end == len(value.value):
+            return self(value.value)
+
+        if isinstance(value.value, ast.Signal):
+            sigspec = self(value.value)
+        else:
+            sigspec = self.s.rtlil.wire(len(value.value))
+            self.s.rtlil.connect(sigspec, self(value.value))
+
+        if value.start + 1 == value.end:
+            return "{} [{}]".format(sigspec, value.start)
+        else:
+            return "{} [{}:{}]".format(sigspec, value.end - 1, value.start)
+
     def on_Part(self, value):
         raise NotImplementedError
 
@@ -433,6 +440,20 @@ class _LHSValueCompiler(_ValueCompiler):
             raise ValueError("Cannot return lhs for non-driven signal {}".format(repr(value)))
         return wire_next
 
+    def on_Slice(self, value):
+        if value.start == 0 and value.end == len(value.value):
+            return self(value.value)
+
+        if isinstance(value.value, ast.Signal):
+            sigspec = self(value.value)
+        else:
+            raise NotImplementedError
+
+        if value.start + 1 == value.end:
+            return "{} [{}]".format(sigspec, value.start)
+        else:
+            return "{} [{}:{}]".format(sigspec, value.end - 1, value.start)
+
     def on_Part(self, value):
         raise NotImplementedError
 
-- 
2.30.2