From 1d87d6f9ca543631b2bc30ac8d82b6a23159fb55 Mon Sep 17 00:00:00 2001 From: Timothy Arceri Date: Fri, 13 Nov 2015 15:16:20 +1100 Subject: [PATCH] glsl: remove duplicate validation for index layout qualifier MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The minimum value for index is validated in apply_explicit_location() and we want to remove validation from the parser so we can add compile time constant support. Reviewed-by: Samuel Iglesias Gonsálvez Reviewed-by: Emil Velikov --- src/glsl/glsl_parser.yy | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index d2d5058befe..a96b18087b8 100644 --- a/src/glsl/glsl_parser.yy +++ b/src/glsl/glsl_parser.yy @@ -1476,13 +1476,7 @@ layout_qualifier_id: } $$.flags.q.explicit_index = 1; - - if ($3 >= 0) { - $$.index = $3; - } else { - _mesa_glsl_error(& @3, state, "invalid index %d specified", $3); - YYERROR; - } + $$.index = $3; } if ((state->has_420pack() || -- 2.30.2