From 1e0cdc10363525fb7688ab6fc8654a5c15248795 Mon Sep 17 00:00:00 2001 From: Alexandre Petit-Bianco Date: Fri, 15 Dec 2000 08:50:12 +0000 Subject: [PATCH] parse.y (end_artificial_method_body): Fixed undefined behavior. 2000-12-15 Alexandre Petit-Bianco * parse.y (end_artificial_method_body): Fixed undefined behavior. Credits go to rth for finding it. (http://gcc.gnu.org/ml/gcc/2000-12/msg00495.html) From-SVN: r38278 --- gcc/java/ChangeLog | 5 +++++ gcc/java/parse.y | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/gcc/java/ChangeLog b/gcc/java/ChangeLog index 4385b49946a..70065a93187 100644 --- a/gcc/java/ChangeLog +++ b/gcc/java/ChangeLog @@ -1,3 +1,8 @@ +2000-12-15 Alexandre Petit-Bianco + + * parse.y (end_artificial_method_body): Fixed undefined behavior. + Credits go to rth for finding it. + 2000-12-13 Mike Stump * parse.y (check_static_final_variable_assignment_flag): Fix spelling. diff --git a/gcc/java/parse.y b/gcc/java/parse.y index 00a55444575..7a23e72b96d 100644 --- a/gcc/java/parse.y +++ b/gcc/java/parse.y @@ -7200,7 +7200,11 @@ static void end_artificial_method_body (mdecl) tree mdecl; { - BLOCK_EXPR_BODY (DECL_FUNCTION_BODY (mdecl)) = exit_block (); + /* exit_block modifies DECL_FUNCTION_BODY (current_function_decl). + It has to be evaluated first. (if mdecl is current_function_decl, + we have an undefined behavior if no temporary variable is used.) */ + tree b = exit_block (); + BLOCK_EXPR_BODY (DECL_FUNCTION_BODY (mdecl)) = b; exit_block (); } -- 2.30.2