From 1e414faa5edaafcdb1b90f8ddefa6aad77386d4d Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Wed, 14 May 2014 18:48:49 +0100 Subject: [PATCH] target-helpers: add a note about debug wrappers If memory serves me right, at least one debug wrapper does not return the base screen on failure. Signed-off-by: Emil Velikov --- src/gallium/auxiliary/target-helpers/inline_debug_helper.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/target-helpers/inline_debug_helper.h b/src/gallium/auxiliary/target-helpers/inline_debug_helper.h index 77c7cfd0c20..6fe667d3fbd 100644 --- a/src/gallium/auxiliary/target-helpers/inline_debug_helper.h +++ b/src/gallium/auxiliary/target-helpers/inline_debug_helper.h @@ -26,6 +26,10 @@ #include "noop/noop_public.h" #endif +/* + * TODO: Audit the following *screen_create() - all of + * them should return the original screen on failuire. + */ static INLINE struct pipe_screen * debug_screen_wrap(struct pipe_screen *screen) { -- 2.30.2