From 1e76a7e9b156173a76e6a14a3ed41cefc9fed480 Mon Sep 17 00:00:00 2001 From: Sergio Durigan Junior Date: Fri, 24 Jul 2015 16:46:49 -0400 Subject: [PATCH] Call gdb_exit before gdb_skip_xml_test on gdb.base/catch-syscall.exp The gdb_skip_xml_test procedure explicitly says that it cannot be invoked when GDB is running. However, the testcase for "catch syscall" is wrongly doing that, which is causing a failure on native-extended-gdbserver tests: new FAIL: gdb.base/catch-syscall.exp: set tdesc filename /home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-native-extended-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/catch-syscall/trivial.xml (got interactive prompt) This obvious commit fixes this, by calling gdb_exit before gdb_skip_xml_test. Checked in as obvious. gdb/testsuite/ChangeLog 2015-07-24 Sergio Durigan Junior * gdb.base/catch-syscall.exp: Call gdb_exit before gdb_skip_xml_test. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/catch-syscall.exp | 1 + 2 files changed, 6 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 8e878f1893c..b0e8e4b890d 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-07-24 Sergio Durigan Junior + + * gdb.base/catch-syscall.exp: Call gdb_exit before + gdb_skip_xml_test. + 2015-07-24 Pedro Alves * gdb.python/py-events.exp: Accept output between the stop event diff --git a/gdb/testsuite/gdb.base/catch-syscall.exp b/gdb/testsuite/gdb.base/catch-syscall.exp index 40ca148c736..499da322267 100644 --- a/gdb/testsuite/gdb.base/catch-syscall.exp +++ b/gdb/testsuite/gdb.base/catch-syscall.exp @@ -509,6 +509,7 @@ setup_all_syscalls fill_all_syscalls_numbers # Execute the tests, using XML support +gdb_exit if { ![gdb_skip_xml_test] } { clean_restart $binfile do_syscall_tests -- 2.30.2