From 1f09ec811eec9ea3a5ef4276f8e94ea6c5e85ef2 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Mon, 8 Mar 2021 07:27:57 -0700 Subject: [PATCH] Split out eval_op_complement This splits UNOP_COMPLEMENT into a new function for future use. gdb/ChangeLog 2021-03-08 Tom Tromey * eval.c (eval_op_complement): New function. (evaluate_subexp_standard): Use it. --- gdb/ChangeLog | 5 +++++ gdb/eval.c | 28 +++++++++++++++++++--------- 2 files changed, 24 insertions(+), 9 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b27ed9c539f..9d39281d52a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2021-03-08 Tom Tromey + + * eval.c (eval_op_complement): New function. + (evaluate_subexp_standard): Use it. + 2021-03-08 Tom Tromey * eval.c (eval_op_neg): New function. diff --git a/gdb/eval.c b/gdb/eval.c index 5cc7b1844f2..f2dacee9f4d 100644 --- a/gdb/eval.c +++ b/gdb/eval.c @@ -1787,6 +1787,24 @@ eval_op_neg (struct type *expect_type, struct expression *exp, } } +/* A helper function for UNOP_COMPLEMENT. */ + +static struct value * +eval_op_complement (struct type *expect_type, struct expression *exp, + enum noside noside, enum exp_opcode op, + struct value *arg1) +{ + if (noside == EVAL_SKIP) + return eval_skip_value (exp); + if (unop_user_defined_p (UNOP_COMPLEMENT, arg1)) + return value_x_unop (arg1, UNOP_COMPLEMENT, noside); + else + { + unop_promote (exp->language_defn, exp->gdbarch, &arg1); + return value_complement (arg1); + } +} + struct value * evaluate_subexp_standard (struct type *expect_type, struct expression *exp, int *pos, @@ -2646,15 +2664,7 @@ evaluate_subexp_standard (struct type *expect_type, /* C++: check for and handle destructor names. */ arg1 = evaluate_subexp (nullptr, exp, pos, noside); - if (noside == EVAL_SKIP) - return eval_skip_value (exp); - if (unop_user_defined_p (UNOP_COMPLEMENT, arg1)) - return value_x_unop (arg1, UNOP_COMPLEMENT, noside); - else - { - unop_promote (exp->language_defn, exp->gdbarch, &arg1); - return value_complement (arg1); - } + return eval_op_complement (expect_type, exp, noside, op, arg1); case UNOP_LOGICAL_NOT: arg1 = evaluate_subexp (nullptr, exp, pos, noside); -- 2.30.2