From 1f141eaef650ba8aada1f289cdb79d7b3b380113 Mon Sep 17 00:00:00 2001 From: Timothy Arceri Date: Tue, 20 Dec 2016 09:39:00 +1100 Subject: [PATCH] glsl: tidy up PostDepthCoverage shader field There is no reason for this to be in the shared gl_shader_info or to copy it to gl_program at the end of linking (its already there). Reviewed-by: Lionel Landwerlin --- src/compiler/glsl/glsl_parser_extras.cpp | 2 +- src/compiler/glsl/linker.cpp | 2 +- src/mesa/main/mtypes.h | 3 ++- src/mesa/main/shaderapi.c | 1 - 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/compiler/glsl/glsl_parser_extras.cpp b/src/compiler/glsl/glsl_parser_extras.cpp index 70bde069e7a..063ca45b307 100644 --- a/src/compiler/glsl/glsl_parser_extras.cpp +++ b/src/compiler/glsl/glsl_parser_extras.cpp @@ -1816,7 +1816,7 @@ set_shader_inout_layout(struct gl_shader *shader, state->ARB_fragment_coord_conventions_enable; shader->EarlyFragmentTests = state->fs_early_fragment_tests; shader->info.InnerCoverage = state->fs_inner_coverage; - shader->info.PostDepthCoverage = state->fs_post_depth_coverage; + shader->PostDepthCoverage = state->fs_post_depth_coverage; shader->BlendSupport = state->fs_blend_support; break; diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index 5f96a7e7447..2bb080a34ac 100644 --- a/src/compiler/glsl/linker.cpp +++ b/src/compiler/glsl/linker.cpp @@ -1881,7 +1881,7 @@ link_fs_inout_layout_qualifiers(struct gl_shader_program *prog, linked_shader->info.InnerCoverage |= shader->info.InnerCoverage; linked_shader->Program->info.fs.post_depth_coverage |= - shader->info.PostDepthCoverage; + shader->PostDepthCoverage; linked_shader->Program->sh.fs.BlendSupport |= shader->BlendSupport; } diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 7b8be09d778..d0e721e0e9d 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -2242,7 +2242,6 @@ struct gl_subroutine_function */ struct gl_shader_info { - bool PostDepthCoverage; bool InnerCoverage; struct { @@ -2430,6 +2429,8 @@ struct gl_shader bool redeclares_gl_fragcoord; bool uses_gl_fragcoord; + bool PostDepthCoverage; + /** * Fragment shader state from GLSL 1.50 layout qualifiers. */ diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 80cac37e8ec..2a7f0a2c828 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -2233,7 +2233,6 @@ _mesa_copy_linked_program_data(const struct gl_shader_program *src, case MESA_SHADER_FRAGMENT: { dst->info.fs.depth_layout = src->FragDepthLayout; dst->info.fs.inner_coverage = dst_sh->info.InnerCoverage; - dst->info.fs.post_depth_coverage = dst_sh->info.PostDepthCoverage; break; } case MESA_SHADER_COMPUTE: { -- 2.30.2