From 1f36144cb0eca2fb07ff20167c79e2b3ee08cd74 Mon Sep 17 00:00:00 2001 From: Mark Kettenis Date: Sat, 17 Aug 2002 10:22:01 +0000 Subject: [PATCH] * gdb.base/return.exp: Remove i*86-*-* from list of xfail'ed targets. The problem should be fixed now. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/return.exp | 17 ++--------------- 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 2b073934e23..a4dca64e48e 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2002-08-17 Mark Kettenis + + * gdb.base/return.exp: Remove i*86-*-* from list of xfail'ed + targets. The problem should be fixed now. + 2002-08-15 Mark Kettenis * gdb.java/jv-print.exp: Fix p '' and p ''' tests to deal with diff --git a/gdb/testsuite/gdb.base/return.exp b/gdb/testsuite/gdb.base/return.exp index e7a536bdac6..2f8946d3020 100644 --- a/gdb/testsuite/gdb.base/return.exp +++ b/gdb/testsuite/gdb.base/return.exp @@ -91,19 +91,6 @@ proc return_tests { } { setup_xfail "m6811-*-*" gdb_test "next" "printf.*" "next over call to func3" - # This test is going to fail on all i*86 systems using an i*87. - # When returning a floating point value from a function, all known - # compilers do this via a `fldl' instruction, which pushes the floating - # value on the i387 stack. This causes two problems: - # a) Most i*86 targets do not store (or cannot store, see comment in - # in i386v-nat.c:i386_register_u_addr) the floating point registers - # to the target. - # b) gdb would have to figure out if the `fldl' instruction (or variants - # of it) has already been executed. If not, it would have to simulate - # a push instruction, as it is not enough to write the register, - # the floating point `stack pointer' has to be updated too. - # Do not expect this to get fixed anytime soon. - # This test also fails for sparc Solaris 2.3 & 2.4, but passes under 2.5 # At the time the `next' is issued, the floating point unit for the # process is not yet initialized, and the storing of the floating @@ -113,8 +100,8 @@ proc return_tests { } { # process start, making this test pass, it will be for a version that # is not xfailed. - setup_xfail "i*86-*-*" "sparc-*-solaris2.3*" "sparc-*-solaris2.4*" "m6811-*-*" - gdb_test "p tmp3" ".* = 5.*" "correct value returned double test (known problem with i*86 and sparc solaris" + setup_xfail "sparc-*-solaris2.3*" "sparc-*-solaris2.4*" "m6811-*-*" + gdb_test "p tmp3" ".* = 5.*" "correct value returned double test (known problem with sparc solaris)" } -- 2.30.2