From 1f3ef5810cab04310a11d4d561a4f32329dfb002 Mon Sep 17 00:00:00 2001 From: Markus Metzger Date: Thu, 28 Mar 2013 10:38:24 +0100 Subject: [PATCH] record-btrace: supply register target methods Supply target methods to allow reading the PC. Forbid anything else. 2014-01-16 Markus Metzger * record-btrace.c (record_btrace_fetch_registers) (record_btrace_store_registers) (record_btrace_to_prepare_to_store): New. (init_record_btrace_ops): Add the above. --- gdb/ChangeLog | 7 ++++ gdb/record-btrace.c | 92 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 99 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 540caf2154b..1bfe4e257b7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2014-01-16 Markus Metzger + + * record-btrace.c (record_btrace_fetch_registers) + (record_btrace_store_registers) + (record_btrace_to_prepare_to_store): New. + (init_record_btrace_ops): Add the above. + 2014-01-16 Tom Tromey * windows-nat.c (windows_prepare_to_store): Add 'self' argument. diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index 9a65146532a..e85e7070699 100644 --- a/gdb/record-btrace.c +++ b/gdb/record-btrace.c @@ -32,6 +32,7 @@ #include "ui-out.h" #include "symtab.h" #include "filenames.h" +#include "regcache.h" /* The target_ops of record-btrace. */ static struct target_ops record_btrace_ops; @@ -750,6 +751,94 @@ record_btrace_is_replaying (void) return 0; } +/* The to_fetch_registers method of target record-btrace. */ + +static void +record_btrace_fetch_registers (struct target_ops *ops, + struct regcache *regcache, int regno) +{ + struct btrace_insn_iterator *replay; + struct thread_info *tp; + + tp = find_thread_ptid (inferior_ptid); + gdb_assert (tp != NULL); + + replay = tp->btrace.replay; + if (replay != NULL) + { + const struct btrace_insn *insn; + struct gdbarch *gdbarch; + int pcreg; + + gdbarch = get_regcache_arch (regcache); + pcreg = gdbarch_pc_regnum (gdbarch); + if (pcreg < 0) + return; + + /* We can only provide the PC register. */ + if (regno >= 0 && regno != pcreg) + return; + + insn = btrace_insn_get (replay); + gdb_assert (insn != NULL); + + regcache_raw_supply (regcache, regno, &insn->pc); + } + else + { + struct target_ops *t; + + for (t = ops->beneath; t != NULL; t = t->beneath) + if (t->to_fetch_registers != NULL) + { + t->to_fetch_registers (t, regcache, regno); + break; + } + } +} + +/* The to_store_registers method of target record-btrace. */ + +static void +record_btrace_store_registers (struct target_ops *ops, + struct regcache *regcache, int regno) +{ + struct target_ops *t; + + if (record_btrace_is_replaying ()) + error (_("This record target does not allow writing registers.")); + + gdb_assert (may_write_registers != 0); + + for (t = ops->beneath; t != NULL; t = t->beneath) + if (t->to_store_registers != NULL) + { + t->to_store_registers (t, regcache, regno); + return; + } + + noprocess (); +} + +/* The to_prepare_to_store method of target record-btrace. */ + +static void +record_btrace_prepare_to_store (struct target_ops *ops, + struct regcache *regcache) +{ + struct target_ops *t; + + if (record_btrace_is_replaying ()) + return; + + for (t = ops->beneath; t != NULL; t = t->beneath) + if (t->to_prepare_to_store != NULL) + { + t->to_prepare_to_store (t, regcache); + return; + } +} + /* Initialize the record-btrace target ops. */ static void @@ -777,6 +866,9 @@ init_record_btrace_ops (void) ops->to_call_history_from = record_btrace_call_history_from; ops->to_call_history_range = record_btrace_call_history_range; ops->to_record_is_replaying = record_btrace_is_replaying; + ops->to_fetch_registers = record_btrace_fetch_registers; + ops->to_store_registers = record_btrace_store_registers; + ops->to_prepare_to_store = record_btrace_prepare_to_store; ops->to_stratum = record_stratum; ops->to_magic = OPS_MAGIC; } -- 2.30.2