From 1fc47f80893f810915a167ed554497f820cb2220 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Sat, 6 Jun 2020 11:58:09 +0930 Subject: [PATCH] Re: PR13802, referred common symbol not UNDefined It looks like this one was previously just swept under the rug. Prior to git commit c4b126b87a6c, the arm backend emitted an absolute dynamic symbol "foo" with value zero for what was originally a common symbol. That was just wrong. The patch also removes an xfail for bfin-linux-uclibc. PR 13802 * testsuite/ld-elf/comm-data.exp: Don't xfail arm or bfin-linux. --- ld/ChangeLog | 4 ++++ ld/testsuite/ld-elf/comm-data.exp | 5 ++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/ld/ChangeLog b/ld/ChangeLog index c3b213f180b..6a0f30b21fb 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,7 @@ +2020-06-06 Alan Modra + + * testsuite/ld-elf/comm-data.exp: Don't xfail arm or bfin-linux. + 2020-06-06 Alan Modra * lexsup.c (ld_options): Accept -plugin and -plugin-opt when diff --git a/ld/testsuite/ld-elf/comm-data.exp b/ld/testsuite/ld-elf/comm-data.exp index c735fe244ce..87ae3b29912 100644 --- a/ld/testsuite/ld-elf/comm-data.exp +++ b/ld/testsuite/ld-elf/comm-data.exp @@ -74,10 +74,9 @@ if [istarget "*-*-hpux*"] { append AFLAGS " --defsym HPUX=1" } -# bfin does not currently support copy relocs. +# bfin-elf does not currently support copy relocs. setup_xfail "bfin-*-*" - -setup_xfail "arm*-*-*" "ld/13802" +clear_xfail "bfin-*-linux-uclibc*" # Verify that a common symbol has been converted to an undefined # reference to the global symbol of the same name defined above -- 2.30.2