From 22e9357028f45fab2563bdf2f3e171d4490a5d05 Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Tue, 21 Jun 2016 18:05:23 +0100 Subject: [PATCH] automake: don't mandate git_sha1.h/MESA_GIT_SHA1 It has proven subtle to get it right both from the build side POV (see commit list below) and builders due to their varying workflows. Furthermore it does not fully fulfil the reason why it was enforced - to detect uniqueness between different builds, in order to distinguish and invalidate Vulkan/GL caches. With that having a much better solution (previous commit) we can drop this solution. This effectively reverts the following commits: 359d9dfec33 ("mesa: automake: add directory prefix for git_sha1.h") 2c424e00c39 ("mesa: automake: ensure that git_sha1.h.tmp has the right attributes") b7f7ec78435 ("mesa: automake: distclean git_sha1.h when building OOT") 8229fe68b5d ("automake: get in-tree `make distclean' working again.") Cc: Timo Aaltonen Cc: Haixia Shi Cc: Jason Ekstrand Cc: mesa-stable@lists.freedesktop.org Signed-off-by: Emil Velikov Reviewed-by: Eric Engestrom --- src/Makefile.am | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 32372da49c1..b130f5b7ced 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -25,15 +25,13 @@ git_sha1.h.tmp: @# a gitlink file if $(top_srcdir) is a submodule checkout or a linked @# worktree. @# If we are building from a release tarball copy the bundled header. + @touch git_sha1.h.tmp @if test -e $(top_srcdir)/.git; then \ if which git > /dev/null; then \ git --git-dir=$(top_srcdir)/.git log -n 1 --oneline | \ sed 's/^\([^ ]*\) .*/#define MESA_GIT_SHA1 "git-\1"/' \ > git_sha1.h.tmp ; \ fi \ - else \ - cp $(srcdir)/git_sha1.h git_sha1.h.tmp ;\ - chmod u+w git_sha1.h.tmp; \ fi git_sha1.h: git_sha1.h.tmp @@ -45,12 +43,7 @@ git_sha1.h: git_sha1.h.tmp fi BUILT_SOURCES = git_sha1.h - -# We want to keep the srcdir file since we need it on rebuild from tarball. -# At the same time `make distclean' gets angry at us if we don't cleanup the -# builddir one. -distclean-local: - ( test $(top_srcdir) != $(top_builddir) && rm $(builddir)/git_sha1.h ) || true +CLEANFILES = $(BUILT_SOURCES) SUBDIRS = . gtest util mapi/glapi/gen mapi @@ -100,7 +93,7 @@ SUBDIRS += gallium endif EXTRA_DIST = \ - getopt hgl SConscript git_sha1.h + getopt hgl SConscript AM_CFLAGS = $(VISIBILITY_CFLAGS) AM_CXXFLAGS = $(VISIBILITY_CXXFLAGS) -- 2.30.2