From 23110678fd44834b018e83a5d278f5a3bb89fb20 Mon Sep 17 00:00:00 2001 From: Giacomo Travaglini Date: Tue, 21 Jan 2020 10:32:52 +0000 Subject: [PATCH] tests: Fix python line break in m5_exit test A bug has been introduced with the new test url. The line break should have used a backslash or (this is the recommended way by PEP8) the implied line continuation via parenthesis. This error was preventing the test to be loaded with the error message: Exception thrown while loading "/tmpfs/src/git/jenkins-gem5-prod/tests/gem5/m5_util/test_exit.py" Ignoring all tests in this file. and was not producing a failure (the test was not run: it was jus ignored). Change-Id: I0afe252d66d2f6546caaf5e7be811f34f88df82c Signed-off-by: Giacomo Travaglini Reviewed-by: Ciro Santilli Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/24625 Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power Tested-by: kokoro --- tests/gem5/m5_util/test_exit.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/gem5/m5_util/test_exit.py b/tests/gem5/m5_util/test_exit.py index e67e37428..42f4215fc 100644 --- a/tests/gem5/m5_util/test_exit.py +++ b/tests/gem5/m5_util/test_exit.py @@ -55,8 +55,8 @@ else: path = joinpath(absdirpath(__file__), '..', 'test-progs', 'hello', 'bin', 'x86', 'linux') filename = 'm5_exit' -url = 'http://dist.gem5.org/dist/current/test-progs/' + - 'm5-exit/bin/x86/linux/m5_exit' +url = ('http://dist.gem5.org/dist/current/test-progs/' + + 'm5-exit/bin/x86/linux/m5_exit') test_program = DownloadedProgram(url, path, filename) a = verifier.MatchRegex(m5_exit_regex) -- 2.30.2