From 239b48db1b238cf5395570604ca4400e74025ab4 Mon Sep 17 00:00:00 2001 From: Tobias Burnus Date: Wed, 23 May 2012 22:35:30 +0200 Subject: [PATCH] re PR fortran/51055 (deferred length character allocation: allocate(character(len=i)::s) rejected) 2012-05-23 Tobias Burnus PR fortran/51055 PR fortran/45170 * match.c (gfc_match_allocate): Set length_from_typespec for characters. * resolve.c (resolve_charlen): If set, don't check whether the len is a specification expression. 2012-05-23 Tobias Burnus PR fortran/51055 PR fortran/45170 * gfortran.dg/allocate_with_typespec_6.f90: New. From-SVN: r187811 --- gcc/fortran/ChangeLog | 9 +++++++++ gcc/fortran/match.c | 3 +++ gcc/fortran/resolve.c | 20 +++++++++++++++---- gcc/testsuite/ChangeLog | 6 ++++++ .../gfortran.dg/allocate_with_typespec_6.f90 | 17 ++++++++++++++++ 5 files changed, 51 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/gfortran.dg/allocate_with_typespec_6.f90 diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog index 38bff786afa..fe13cc551d4 100644 --- a/gcc/fortran/ChangeLog +++ b/gcc/fortran/ChangeLog @@ -1,3 +1,12 @@ +2012-05-23 Tobias Burnus + + PR fortran/51055 + PR fortran/45170 + * match.c (gfc_match_allocate): Set length_from_typespec + for characters. + * resolve.c (resolve_charlen): If set, don't check whether + the len is a specification expression. + 2012-05-22 Tobias Burnus PR fortran/53389 diff --git a/gcc/fortran/match.c b/gcc/fortran/match.c index 3d119180a73..93d7fab61b6 100644 --- a/gcc/fortran/match.c +++ b/gcc/fortran/match.c @@ -3466,6 +3466,9 @@ gfc_match_allocate (void) "type parameter", &old_locus); goto cleanup; } + + if (ts.type == BT_CHARACTER) + ts.u.cl->length_from_typespec = true; } else { diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c index 9814c14753a..a56d3f702ef 100644 --- a/gcc/fortran/resolve.c +++ b/gcc/fortran/resolve.c @@ -9945,12 +9945,24 @@ resolve_charlen (gfc_charlen *cl) cl->resolved = 1; - specification_expr = 1; - if (resolve_index_expr (cl->length) == FAILURE) + if (cl->length_from_typespec) { - specification_expr = 0; - return FAILURE; + if (gfc_resolve_expr (cl->length) == FAILURE) + return FAILURE; + + if (gfc_simplify_expr (cl->length, 0) == FAILURE) + return FAILURE; + } + else + { + specification_expr = 1; + + if (resolve_index_expr (cl->length) == FAILURE) + { + specification_expr = 0; + return FAILURE; + } } /* "If the character length parameter value evaluates to a negative diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 35dd366c5e6..f337a296910 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2012-05-23 Tobias Burnus + + PR fortran/51055 + PR fortran/45170 + * gfortran.dg/allocate_with_typespec_6.f90: New. + 2012-05-23 Paolo Carlini PR c++/29185 diff --git a/gcc/testsuite/gfortran.dg/allocate_with_typespec_6.f90 b/gcc/testsuite/gfortran.dg/allocate_with_typespec_6.f90 new file mode 100644 index 00000000000..cd130761a1b --- /dev/null +++ b/gcc/testsuite/gfortran.dg/allocate_with_typespec_6.f90 @@ -0,0 +1,17 @@ +! { dg-do compile } +! +! PR fortran/51055 +! PR fortran/45170 comment 14 +! +! Contributed by Juha Ruokolainen +! and Hans-Werner Boschmann +! +! gfortran was before checking whether the length +! was a specification expression. +! + +program a + character(len=:), allocatable :: s + integer :: i=10 + allocate(character(len=i)::s) +end program a -- 2.30.2