From 23e829301bd42b3964f457d50e462195d4343590 Mon Sep 17 00:00:00 2001 From: Luis Machado Date: Fri, 20 Jan 2017 13:58:40 -0600 Subject: [PATCH] Fix uppercase test names in gdb.python/py-xmethods.exp Some leftover uppercase test names in py-xmethods.exp. The patch also replaces two "continue" calls with untested calls to make things a bit more clear. gdb/testsuite/ChangeLog: 2017-01-20 Luis Machado * gdb.python/py-xmethods.exp: Fix test names starting with lowercase and add untested calls. --- gdb/testsuite/ChangeLog | 5 +++ gdb/testsuite/gdb.python/py-xmethods.exp | 46 +++++++++++++----------- 2 files changed, 31 insertions(+), 20 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 3af1d65b564..4d197116132 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2017-01-20 Luis Machado + + * gdb.python/py-xmethods.exp: Fix test names starting with lowercase + and add untested calls. + 2017-01-20 Luis Machado * gdb.python/python.exp: Check line number against what GDB thinks diff --git a/gdb/testsuite/gdb.python/py-xmethods.exp b/gdb/testsuite/gdb.python/py-xmethods.exp index 8f5bf16a9bf..dcd7191283f 100644 --- a/gdb/testsuite/gdb.python/py-xmethods.exp +++ b/gdb/testsuite/gdb.python/py-xmethods.exp @@ -18,7 +18,10 @@ load_lib gdb-python.exp -if { [skip_cplus_tests] } { continue } +if { [skip_cplus_tests] } { + untested "skipping C++ tests" + return +} standard_testfile py-xmethods.cc @@ -27,7 +30,10 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } # Skip all tests if Python scripting is not enabled. -if { [skip_python_tests] } { continue } +if { [skip_python_tests] } { + untested "skipping Python tests" + return +} if ![runto_main] { return -1 @@ -54,7 +60,7 @@ gdb_test "p a_geta" ".* = 1" "before: a_geta 1" gdb_test "p ++a1" "No symbol.*" "before: ++a1" gdb_test "p a1.getarrayind(5)" "Couldn't find method.*" \ - "Before: a1.getarrayind(5)" + "before: a1.getarrayind(5)" gdb_test "p a_ptr->geta()" ".* = 60" "before: a_ptr->geta()" gdb_test "p b_geta" ".* = 1" "before: b_geta 1" @@ -68,19 +74,19 @@ gdb_test "p g.size_diff()" ".*" "before: call g.size_diff()" gdb_test "p g_size_diff" ".* = 2" "before: g_size_diff 2" gdb_test "p g.size_diff()" "Couldn't find method.*" \ - "Before: g.size_diff()" + "before: g.size_diff()" gdb_test "p g.size_mul<2>()" ".*" "before: g.size_mul<2>()" gdb_test "p g_size_mul" ".* = 2" "before: g_size_mul 2" gdb_test "p g.size_mul<5>()" "Couldn't find method.*" \ - "Before: g.size_mul<5>()" + "before: g.size_mul<5>()" gdb_test "p g.mul(2.0)" ".* = 10" "before: g.mul(2.0)" gdb_test "p g_mul" ".* = 2" "before: g_mul 2" gdb_test "p g.mul('a')" "Couldn't find method.*" \ - "Before: g.mul('a')" + "before: g.mul('a')" # Load the script which adds the debug methods. gdb_test_no_output "source ${xmethods_script}" "load the script file" @@ -99,7 +105,7 @@ gdb_test "p a_minus_a" ".* = 4" "after: a_minus_a 4" gdb_test "p a1.geta()" "From Python .*5" "after: a1.geta()" gdb_test "p ++a1" "From Python .*6" "after: ++a1" gdb_test "p a1.getarrayind(5)" "From Python .*5" \ - "After: a1.getarrayind(5)" + "after: a1.getarrayind(5)" gdb_test "P a1\[6\]" ".*int &.*6" "after a1\[\]" gdb_test "P b1\[7\]" ".*const int &.*7" "after b1\[\]" # Note the following test. Xmethods on dynamc types are not looked up @@ -110,40 +116,40 @@ gdb_test "p e.geta()" "From Python .*100" "after: e.geta()" gdb_test "p e_ptr->geta()" "From Python .*100" "after: e_ptr->geta()" gdb_test "p e_ref.geta()" "From Python .*100" "after: e_ref.geta()" gdb_test "p e.method(10)" "From Python .* = void" \ - "After: e.method(10)" + "after: e.method(10)" gdb_test "p e.method('a')" "From Python .* = void" \ - "After: e.method('a')" + "after: e.method('a')" gdb_test "p g.size_diff ()" "From Python G<>::size_diff.*" \ - "After: g.size_diff()" + "after: g.size_diff()" gdb_test "p g.size_diff< unsigned long >()" "From Python G<>::size_diff.*" \ - "After: g.size_diff()" + "after: g.size_diff()" gdb_test "p g.size_mul<2>()" "From Python G<>::size_mul.*" \ - "After: g.size_mul<2>()" + "after: g.size_mul<2>()" gdb_test "p g.size_mul< 5 >()" "From Python G<>::size_mul.*" \ - "After: g.size_mul< 5 >()" + "after: g.size_mul< 5 >()" gdb_test "p g.mul(2.0)" "From Python G<>::mul.*" \ - "After: g.mul(2.0)" + "after: g.mul(2.0)" gdb_test "p g.mul('a')" "From Python G<>::mul.*" \ gdb_test "p g_ptr->mul('a')" "From Python G<>::mul.*" \ "after: g_ptr->mul('a')" # Tests for 'disable/enable xmethod' command. gdb_test_no_output "disable xmethod progspace G_methods" \ - "Disable G_methods" + "disable G_methods" gdb_test "p g.mul('a')" "Couldn't find method.*" \ "g.mul('a') after disabling G_methods" gdb_test_no_output "enable xmethod progspace G_methods" \ - "Enable G_methods" + "dnable G_methods" gdb_test "p g.mul('a')" "From Python G<>::mul.*" \ - "After enabling G_methods" + "after enabling G_methods" gdb_test_no_output "disable xmethod progspace G_methods;mul" \ - "Disable G_methods;mul" + "disable G_methods;mul" gdb_test "p g.mul('a')" "Couldn't find method.*" \ "g.mul('a') after disabling G_methods;mul" gdb_test_no_output "enable xmethod progspace G_methods;mul" \ - "Enable G_methods;mul" + "enable G_methods;mul" gdb_test "p g.mul('a')" "From Python G<>::mul.*" \ - "After enabling G_methods;mul" + "after enabling G_methods;mul" # Test for 'info xmethods' command gdb_test "info xmethod global plus" "global.*plus_plus_A" \ -- 2.30.2