From 247d6c4c14769b7576d810a381a68e35388ee874 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Thu, 16 Feb 2017 12:23:12 +1030 Subject: [PATCH] PR21132, hppa-linux pie support doesn't work This fixes a long-standing hppa bug seen when generating PIEs, and I think possible to trigger with forced local symbols in shared libraries. Not allocating enough space for PLT relocs results in ld writing outside of the buffer. PR 21132 * elf32-hppa.c (allocate_plt_static): Allocate space for relocs if pic. --- bfd/ChangeLog | 6 ++++++ bfd/elf32-hppa.c | 2 ++ 2 files changed, 8 insertions(+) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index a6a4c646b61..4be12b80227 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2017-02-16 Alan Modra + + PR 21132 + * elf32-hppa.c (allocate_plt_static): Allocate space for relocs + if pic. + 2017-02-16 Jiong Wang * bfd.c (BFD_FLAGS_SAVED): Add BFD_LINKER_CREATED. diff --git a/bfd/elf32-hppa.c b/bfd/elf32-hppa.c index de14468a27e..e64ea9aff98 100644 --- a/bfd/elf32-hppa.c +++ b/bfd/elf32-hppa.c @@ -1976,6 +1976,8 @@ allocate_plt_static (struct elf_link_hash_entry *eh, void *inf) sec = htab->etab.splt; eh->plt.offset = sec->size; sec->size += PLT_ENTRY_SIZE; + if (bfd_link_pic (info)) + htab->etab.srelplt->size += sizeof (Elf32_External_Rela); } else { -- 2.30.2