From 253e8edf13c4d7bee6bd13f84fdfa6cf40a0c5c3 Mon Sep 17 00:00:00 2001 From: Nilay Vaish Date: Sun, 10 Feb 2013 21:43:10 -0600 Subject: [PATCH] ruby: replace Time with Cycles (final patch in the series) This patch is as of now the final patch in the series of patches that replace Time with Cycles.This patch further replaces Time with Cycles in Sequencer, Profiler, different protocols and related entities. Though Time has not been completely removed, the places where it is in use seem benign as of now. --- src/mem/protocol/MOESI_CMP_token-L1cache.sm | 6 +-- src/mem/protocol/MOESI_hammer-cache.sm | 12 +++-- src/mem/protocol/MOESI_hammer-dir.sm | 2 +- src/mem/protocol/MOESI_hammer-msg.sm | 14 ++++-- src/mem/protocol/RubySlicc_Exports.sm | 3 +- src/mem/protocol/RubySlicc_Profiler.sm | 2 +- src/mem/protocol/RubySlicc_Types.sm | 10 +++-- src/mem/protocol/RubySlicc_Util.sm | 7 +-- src/mem/ruby/common/TypeDefines.hh | 1 - src/mem/ruby/profiler/Profiler.cc | 30 ++++++------- src/mem/ruby/profiler/Profiler.hh | 32 +++++--------- .../slicc_interface/AbstractController.cc | 2 +- .../slicc_interface/AbstractController.hh | 2 +- .../ruby/slicc_interface/RubySlicc_Util.hh | 34 +------------- src/mem/ruby/structures/Prefetcher.cc | 2 +- src/mem/ruby/system/Sequencer.cc | 34 +++++++------- src/mem/ruby/system/Sequencer.hh | 44 +++++++++---------- src/mem/ruby/system/TBETable.hh | 3 -- src/mem/ruby/system/TimerTable.cc | 2 +- src/mem/ruby/system/TimerTable.hh | 2 +- src/mem/slicc/ast/InfixOperatorExprAST.py | 1 - 21 files changed, 103 insertions(+), 142 deletions(-) diff --git a/src/mem/protocol/MOESI_CMP_token-L1cache.sm b/src/mem/protocol/MOESI_CMP_token-L1cache.sm index 365a963b9..02737a4f6 100644 --- a/src/mem/protocol/MOESI_CMP_token-L1cache.sm +++ b/src/mem/protocol/MOESI_CMP_token-L1cache.sm @@ -153,7 +153,7 @@ machine(L1Cache, "Token protocol") bool IsAtomic, default="false", desc="Request was an atomic request"; AccessType AccessType, desc="Type of request (used for profiling)"; - Time IssueTime, desc="Time the request was issued"; + Cycles IssueTime, desc="Time the request was issued"; RubyAccessMode AccessMode, desc="user/supervisor access type"; PrefetchBit Prefetch, desc="Is this a prefetch request"; } @@ -183,7 +183,7 @@ machine(L1Cache, "Token protocol") void unset_tbe(); void wakeUpAllBuffers(); void wakeUpBuffers(Address a); - Time curCycle(); + Cycles curCycle(); TBETable L1_TBEs, template="", constructor="m_number_of_TBEs"; @@ -1452,7 +1452,7 @@ machine(L1Cache, "Token protocol") // Update average latency if (tbe.IssueCount <= 1) { if (tbe.ExternalResponse == true) { - updateAverageLatencyEstimate(TimeToCycles(curCycle() - tbe.IssueTime)); + updateAverageLatencyEstimate(curCycle() - tbe.IssueTime); } } diff --git a/src/mem/protocol/MOESI_hammer-cache.sm b/src/mem/protocol/MOESI_hammer-cache.sm index fc2a9da90..bc3b700d3 100644 --- a/src/mem/protocol/MOESI_hammer-cache.sm +++ b/src/mem/protocol/MOESI_hammer-cache.sm @@ -161,9 +161,13 @@ machine(L1Cache, "AMD Hammer-like protocol") bool AppliedSilentAcks, default="false", desc="for full-bit dir, does the pending msg count reflect the silent acks"; MachineID LastResponder, desc="last machine to send a response for this request"; MachineID CurOwner, desc="current owner of the block, used for UnblockS responses"; - Time InitialRequestTime, default="0", desc="time the initial requests was sent from the L1Cache"; - Time ForwardRequestTime, default="0", desc="time the dir forwarded the request"; - Time FirstResponseTime, default="0", desc="the time the first response was received"; + + Cycles InitialRequestTime, default="Cycles(0)", + desc="time the initial requests was sent from the L1Cache"; + Cycles ForwardRequestTime, default="Cycles(0)", + desc="time the dir forwarded the request"; + Cycles FirstResponseTime, default="Cycles(0)", + desc="the time the first response was received"; } structure(TBETable, external="yes") { @@ -181,7 +185,7 @@ machine(L1Cache, "AMD Hammer-like protocol") void unset_tbe(); void wakeUpAllBuffers(); void wakeUpBuffers(Address a); - Time curCycle(); + Cycles curCycle(); Entry getCacheEntry(Address address), return_by_pointer="yes" { Entry L2cache_entry := static_cast(Entry, "pointer", L2cacheMemory.lookup(address)); diff --git a/src/mem/protocol/MOESI_hammer-dir.sm b/src/mem/protocol/MOESI_hammer-dir.sm index 40f4db73e..e1ed2feef 100644 --- a/src/mem/protocol/MOESI_hammer-dir.sm +++ b/src/mem/protocol/MOESI_hammer-dir.sm @@ -179,7 +179,7 @@ machine(Directory, "AMD Hammer-like protocol") void set_tbe(TBE a); void unset_tbe(); void wakeUpBuffers(Address a); - Time curCycle(); + Cycles curCycle(); // ** OBJECTS ** diff --git a/src/mem/protocol/MOESI_hammer-msg.sm b/src/mem/protocol/MOESI_hammer-msg.sm index 41d176a9c..eef78ba45 100644 --- a/src/mem/protocol/MOESI_hammer-msg.sm +++ b/src/mem/protocol/MOESI_hammer-msg.sm @@ -94,8 +94,11 @@ structure(RequestMsg, desc="...", interface="NetworkMessage") { NetDest Destination, desc="Multicast destination mask"; MessageSizeType MessageSize, desc="size category of the message"; bool DirectedProbe, default="false", desc="probe filter directed probe"; - Time InitialRequestTime, default="0", desc="time the initial requests was sent from the L1Cache"; - Time ForwardRequestTime, default="0", desc="time the dir forwarded the request"; + + Cycles InitialRequestTime, default="Cycles(0)", + desc="time the initial requests was sent from the L1Cache"; + Cycles ForwardRequestTime, default="Cycles(0)", + desc="time the dir forwarded the request"; int SilentAcks, default="0", desc="silent acks from the full-bit directory"; bool functionalRead(Packet *pkt) { @@ -120,8 +123,11 @@ structure(ResponseMsg, desc="...", interface="NetworkMessage") { bool Dirty, desc="Is the data dirty (different than memory)?"; int Acks, default="0", desc="How many messages this counts as"; MessageSizeType MessageSize, desc="size category of the message"; - Time InitialRequestTime, default="0", desc="time the initial requests was sent from the L1Cache"; - Time ForwardRequestTime, default="0", desc="time the dir forwarded the request"; + + Cycles InitialRequestTime, default="Cycles(0)", + desc="time the initial requests was sent from the L1Cache"; + Cycles ForwardRequestTime, default="Cycles(0)", + desc="time the dir forwarded the request"; int SilentAcks, default="0", desc="silent acks from the full-bit directory"; bool functionalRead(Packet *pkt) { diff --git a/src/mem/protocol/RubySlicc_Exports.sm b/src/mem/protocol/RubySlicc_Exports.sm index 8ca1ed32c..036419095 100644 --- a/src/mem/protocol/RubySlicc_Exports.sm +++ b/src/mem/protocol/RubySlicc_Exports.sm @@ -33,11 +33,10 @@ external_type(bool, primitive="yes", default="false"); external_type(std::string, primitive="yes"); external_type(uint32_t, primitive="yes"); external_type(uint64, primitive="yes"); -external_type(Time, primitive="yes", default="0"); external_type(PacketPtr, primitive="yes"); external_type(Packet, primitive="yes"); external_type(Address); -external_type(Cycles, primitive="yes"); +external_type(Cycles, primitive="yes", default="Cycles(0)"); structure(DataBlock, external = "yes", desc="..."){ void clear(); diff --git a/src/mem/protocol/RubySlicc_Profiler.sm b/src/mem/protocol/RubySlicc_Profiler.sm index 64f643054..e09f30056 100644 --- a/src/mem/protocol/RubySlicc_Profiler.sm +++ b/src/mem/protocol/RubySlicc_Profiler.sm @@ -47,4 +47,4 @@ void profile_outstanding_persistent_request(int outstanding); void profile_average_latency_estimate(int latency); // profile the total message delay of a message across a virtual network -void profileMsgDelay(int virtualNetwork, Time delayCycles); +void profileMsgDelay(int virtualNetwork, Cycles delayCycles); diff --git a/src/mem/protocol/RubySlicc_Types.sm b/src/mem/protocol/RubySlicc_Types.sm index 0f6cd0b96..096215386 100644 --- a/src/mem/protocol/RubySlicc_Types.sm +++ b/src/mem/protocol/RubySlicc_Types.sm @@ -41,7 +41,7 @@ external_type(OutPort, primitive="yes"); structure(InPort, external = "yes", primitive="yes") { bool isReady(); void dequeue(); - Time dequeue_getDelayCycles(); + Cycles dequeue_getDelayCycles(); void recycle(); bool isEmpty(); } @@ -97,10 +97,14 @@ structure (NetDest, external = "yes", non_obj="yes") { structure (Sequencer, external = "yes") { void readCallback(Address, DataBlock); void readCallback(Address, GenericMachineType, DataBlock); - void readCallback(Address, GenericMachineType, DataBlock, Time, Time, Time); + void readCallback(Address, GenericMachineType, DataBlock, + Cycles, Cycles, Cycles); + void writeCallback(Address, DataBlock); void writeCallback(Address, GenericMachineType, DataBlock); - void writeCallback(Address, GenericMachineType, DataBlock, Time, Time, Time); + void writeCallback(Address, GenericMachineType, DataBlock, + Cycles, Cycles, Cycles); + void checkCoherence(Address); void profileNack(Address, int, int, uint64); void evictionCallback(Address); diff --git a/src/mem/protocol/RubySlicc_Util.sm b/src/mem/protocol/RubySlicc_Util.sm index 238884503..0d0e63d85 100644 --- a/src/mem/protocol/RubySlicc_Util.sm +++ b/src/mem/protocol/RubySlicc_Util.sm @@ -32,14 +32,9 @@ void error(std::string msg); void assert(bool condition); int random(int number); -Time zero_time(); -Cycles TimeToCycles(Time t); +Cycles zero_time(); NodeID intToID(int nodenum); int IDToInt(NodeID id); -int time_to_int(Time time); -Time getTimeModInt(Time time, int modulus); -Time getTimePlusInt(Time addend1, int addend2); -Time getTimeMinusTime(Time t1, Time t2); void procProfileCoherenceRequest(NodeID node, bool needCLB); void dirProfileCoherenceRequest(NodeID node, bool needCLB); int max_tokens(); diff --git a/src/mem/ruby/common/TypeDefines.hh b/src/mem/ruby/common/TypeDefines.hh index b031a62d3..af1a6ca4c 100644 --- a/src/mem/ruby/common/TypeDefines.hh +++ b/src/mem/ruby/common/TypeDefines.hh @@ -31,7 +31,6 @@ #define TYPEDEFINES_H typedef unsigned long long uint64; - typedef long long int64; typedef int64 Time; diff --git a/src/mem/ruby/profiler/Profiler.cc b/src/mem/ruby/profiler/Profiler.cc index 165561fe8..e15285784 100644 --- a/src/mem/ruby/profiler/Profiler.cc +++ b/src/mem/ruby/profiler/Profiler.cc @@ -270,7 +270,7 @@ Profiler::printStats(ostream& out, bool short_stats) double minutes = seconds / 60.0; double hours = minutes / 60.0; double days = hours / 24.0; - Time ruby_cycles = g_system_ptr->getTime()-m_ruby_start; + Cycles ruby_cycles = g_system_ptr->getTime()-m_ruby_start; if (!short_stats) { out << "Elapsed_time_in_seconds: " << seconds << endl; @@ -609,7 +609,7 @@ Profiler::profileSharing(const Address& addr, AccessType type, } void -Profiler::profilePFWait(Time waitTime) +Profiler::profilePFWait(Cycles waitTime) { m_prefetchWaitHistogram.add(waitTime); } @@ -622,7 +622,7 @@ Profiler::bankBusy() // non-zero cycle demand request void -Profiler::missLatency(Time cycles, +Profiler::missLatency(Cycles cycles, RubyRequestType type, const GenericMachineType respondingMach) { @@ -633,11 +633,11 @@ Profiler::missLatency(Time cycles, } void -Profiler::missLatencyWcc(Time issuedTime, - Time initialRequestTime, - Time forwardRequestTime, - Time firstResponseTime, - Time completionTime) +Profiler::missLatencyWcc(Cycles issuedTime, + Cycles initialRequestTime, + Cycles forwardRequestTime, + Cycles firstResponseTime, + Cycles completionTime) { if ((issuedTime <= initialRequestTime) && (initialRequestTime <= forwardRequestTime) && @@ -659,11 +659,11 @@ Profiler::missLatencyWcc(Time issuedTime, } void -Profiler::missLatencyDir(Time issuedTime, - Time initialRequestTime, - Time forwardRequestTime, - Time firstResponseTime, - Time completionTime) +Profiler::missLatencyDir(Cycles issuedTime, + Cycles initialRequestTime, + Cycles forwardRequestTime, + Cycles firstResponseTime, + Cycles completionTime) { if ((issuedTime <= initialRequestTime) && (initialRequestTime <= forwardRequestTime) && @@ -686,13 +686,13 @@ Profiler::missLatencyDir(Time issuedTime, // non-zero cycle prefetch request void -Profiler::swPrefetchLatency(Time cycles, - RubyRequestType type, +Profiler::swPrefetchLatency(Cycles cycles, RubyRequestType type, const GenericMachineType respondingMach) { m_allSWPrefetchLatencyHistogram.add(cycles); m_SWPrefetchLatencyHistograms[type].add(cycles); m_SWPrefetchMachLatencyHistograms[respondingMach].add(cycles); + if (respondingMach == GenericMachineType_Directory || respondingMach == GenericMachineType_NUM) { m_SWPrefetchL2MissLatencyHistogram.add(cycles); diff --git a/src/mem/ruby/profiler/Profiler.hh b/src/mem/ruby/profiler/Profiler.hh index ecd57c035..421e8fe55 100644 --- a/src/mem/ruby/profiler/Profiler.hh +++ b/src/mem/ruby/profiler/Profiler.hh @@ -125,29 +125,23 @@ class Profiler : public SimObject void startTransaction(int cpu); void endTransaction(int cpu); - void profilePFWait(Time waitTime); + void profilePFWait(Cycles waitTime); void controllerBusy(MachineID machID); void bankBusy(); - void missLatency(Time t, - RubyRequestType type, + void missLatency(Cycles t, RubyRequestType type, const GenericMachineType respondingMach); - void missLatencyWcc(Time issuedTime, - Time initialRequestTime, - Time forwardRequestTime, - Time firstResponseTime, - Time completionTime); + void missLatencyWcc(Cycles issuedTime, Cycles initialRequestTime, + Cycles forwardRequestTime, Cycles firstResponseTime, + Cycles completionTime); - void missLatencyDir(Time issuedTime, - Time initialRequestTime, - Time forwardRequestTime, - Time firstResponseTime, - Time completionTime); + void missLatencyDir(Cycles issuedTime, Cycles initialRequestTime, + Cycles forwardRequestTime, Cycles firstResponseTime, + Cycles completionTime); - void swPrefetchLatency(Time t, - RubyRequestType type, + void swPrefetchLatency(Cycles t, RubyRequestType type, const GenericMachineType respondingMach); void sequencerRequests(int num) { m_sequencer_requests.add(num); } @@ -158,11 +152,7 @@ class Profiler : public SimObject bool watchAddress(Address addr); // return Ruby's start time - Time - getRubyStartTime() - { - return m_ruby_start; - } + Cycles getRubyStartTime() { return m_ruby_start; } // added by SS bool getHotLines() { return m_hot_lines; } @@ -186,7 +176,7 @@ class Profiler : public SimObject std::ostream* m_periodic_output_file_ptr; int64_t m_stats_period; - Time m_ruby_start; + Cycles m_ruby_start; time_t m_real_time_start_time; int64_t m_busyBankCount; diff --git a/src/mem/ruby/slicc_interface/AbstractController.cc b/src/mem/ruby/slicc_interface/AbstractController.cc index bcd09796a..9a0ee2b2b 100644 --- a/src/mem/ruby/slicc_interface/AbstractController.cc +++ b/src/mem/ruby/slicc_interface/AbstractController.cc @@ -73,7 +73,7 @@ AbstractController::profileRequest(const std::string &request) } void -AbstractController::profileMsgDelay(uint32_t virtualNetwork, Time delay) +AbstractController::profileMsgDelay(uint32_t virtualNetwork, Cycles delay) { assert(virtualNetwork < m_delayVCHistogram.size()); m_delayHistogram.add(delay); diff --git a/src/mem/ruby/slicc_interface/AbstractController.hh b/src/mem/ruby/slicc_interface/AbstractController.hh index 44981a7e8..ba0c4b683 100644 --- a/src/mem/ruby/slicc_interface/AbstractController.hh +++ b/src/mem/ruby/slicc_interface/AbstractController.hh @@ -101,7 +101,7 @@ class AbstractController : public ClockedObject, public Consumer //! Profiles original cache requests including PUTs void profileRequest(const std::string &request); //! Profiles the delay associated with messages. - void profileMsgDelay(uint32_t virtualNetwork, Time delay); + void profileMsgDelay(uint32_t virtualNetwork, Cycles delay); protected: int m_transitions_per_cycle; diff --git a/src/mem/ruby/slicc_interface/RubySlicc_Util.hh b/src/mem/ruby/slicc_interface/RubySlicc_Util.hh index 622efd04c..75048136f 100644 --- a/src/mem/ruby/slicc_interface/RubySlicc_Util.hh +++ b/src/mem/ruby/slicc_interface/RubySlicc_Util.hh @@ -46,12 +46,7 @@ random(int n) return random() % n; } -inline Time -zero_time() -{ - return 0; -} - +inline Cycles zero_time() { return Cycles(0); } inline Cycles TimeToCycles(Time t) { return Cycles(t); } inline NodeID @@ -68,33 +63,6 @@ IDToInt(NodeID id) return nodenum; } -inline Time -getTimeModInt(Time time, int modulus) -{ - return time % modulus; -} - -inline Time -getTimePlusInt(Time addend1, int addend2) -{ - return (Time) addend1 + addend2; -} - -inline Time -getTimeMinusTime(Time t1, Time t2) -{ - assert(t1 >= t2); - return t1 - t2; -} - -// Return type for time_to_int is "Time" and not "int" so we get a -// 64-bit integer -inline Time -time_to_int(Time time) -{ - return time; -} - // Appends an offset to an address inline Address setOffset(Address addr, int offset) diff --git a/src/mem/ruby/structures/Prefetcher.cc b/src/mem/ruby/structures/Prefetcher.cc index 47caf1cc8..05a1d8e62 100644 --- a/src/mem/ruby/structures/Prefetcher.cc +++ b/src/mem/ruby/structures/Prefetcher.cc @@ -257,7 +257,7 @@ uint32_t Prefetcher::getLRUindex(void) { uint32_t lru_index = 0; - Time lru_access = m_array[lru_index].m_use_time; + Cycles lru_access = m_array[lru_index].m_use_time; for (uint32_t i = 0; i < m_num_streams; i++) { if (!m_array[i].m_is_valid) { diff --git a/src/mem/ruby/system/Sequencer.cc b/src/mem/ruby/system/Sequencer.cc index 3481369bb..94ad42d9d 100644 --- a/src/mem/ruby/system/Sequencer.cc +++ b/src/mem/ruby/system/Sequencer.cc @@ -359,19 +359,19 @@ Sequencer::writeCallback(const Address& address, DataBlock& data) void Sequencer::writeCallback(const Address& address, - GenericMachineType mach, + GenericMachineType mach, DataBlock& data) { - writeCallback(address, mach, data, 0, 0, 0); + writeCallback(address, mach, data, Cycles(0), Cycles(0), Cycles(0)); } void Sequencer::writeCallback(const Address& address, - GenericMachineType mach, + GenericMachineType mach, DataBlock& data, - Time initialRequestTime, - Time forwardRequestTime, - Time firstResponseTime) + Cycles initialRequestTime, + Cycles forwardRequestTime, + Cycles firstResponseTime) { assert(address == line_address(address)); assert(m_writeRequestTable.count(line_address(address))); @@ -410,7 +410,7 @@ Sequencer::writeCallback(const Address& address, m_controller->unblock(address); } - hitCallback(request, mach, data, success, + hitCallback(request, mach, data, success, initialRequestTime, forwardRequestTime, firstResponseTime); } @@ -425,16 +425,16 @@ Sequencer::readCallback(const Address& address, GenericMachineType mach, DataBlock& data) { - readCallback(address, mach, data, 0, 0, 0); + readCallback(address, mach, data, Cycles(0), Cycles(0), Cycles(0)); } void Sequencer::readCallback(const Address& address, GenericMachineType mach, DataBlock& data, - Time initialRequestTime, - Time forwardRequestTime, - Time firstResponseTime) + Cycles initialRequestTime, + Cycles forwardRequestTime, + Cycles firstResponseTime) { assert(address == line_address(address)); assert(m_readRequestTable.count(line_address(address))); @@ -449,7 +449,7 @@ Sequencer::readCallback(const Address& address, assert((request->m_type == RubyRequestType_LD) || (request->m_type == RubyRequestType_IFETCH)); - hitCallback(request, mach, data, true, + hitCallback(request, mach, data, true, initialRequestTime, forwardRequestTime, firstResponseTime); } @@ -458,16 +458,16 @@ Sequencer::hitCallback(SequencerRequest* srequest, GenericMachineType mach, DataBlock& data, bool success, - Time initialRequestTime, - Time forwardRequestTime, - Time firstResponseTime) + Cycles initialRequestTime, + Cycles forwardRequestTime, + Cycles firstResponseTime) { PacketPtr pkt = srequest->pkt; Address request_address(pkt->getAddr()); Address request_line_address(pkt->getAddr()); request_line_address.makeLineAddress(); RubyRequestType type = srequest->m_type; - Time issued_time = srequest->issue_time; + Cycles issued_time = srequest->issue_time; // Set this cache entry to the most recently used if (type == RubyRequestType_IFETCH) { @@ -477,7 +477,7 @@ Sequencer::hitCallback(SequencerRequest* srequest, } assert(curCycle() >= issued_time); - Time miss_latency = curCycle() - issued_time; + Cycles miss_latency = curCycle() - issued_time; // Profile the miss latency for all non-zero demand misses if (miss_latency != 0) { diff --git a/src/mem/ruby/system/Sequencer.hh b/src/mem/ruby/system/Sequencer.hh index 3fccd2566..b3ec4d10a 100644 --- a/src/mem/ruby/system/Sequencer.hh +++ b/src/mem/ruby/system/Sequencer.hh @@ -70,29 +70,29 @@ class Sequencer : public RubyPort void writeCallback(const Address& address, DataBlock& data); - void writeCallback(const Address& address, - GenericMachineType mach, + void writeCallback(const Address& address, + GenericMachineType mach, DataBlock& data); - void writeCallback(const Address& address, - GenericMachineType mach, + void writeCallback(const Address& address, + GenericMachineType mach, DataBlock& data, - Time initialRequestTime, - Time forwardRequestTime, - Time firstResponseTime); + Cycles initialRequestTime, + Cycles forwardRequestTime, + Cycles firstResponseTime); void readCallback(const Address& address, DataBlock& data); - void readCallback(const Address& address, - GenericMachineType mach, + void readCallback(const Address& address, + GenericMachineType mach, DataBlock& data); - void readCallback(const Address& address, - GenericMachineType mach, + void readCallback(const Address& address, + GenericMachineType mach, DataBlock& data, - Time initialRequestTime, - Time forwardRequestTime, - Time firstResponseTime); + Cycles initialRequestTime, + Cycles forwardRequestTime, + Cycles firstResponseTime); RequestStatus makeRequest(PacketPtr pkt); bool empty() const; @@ -122,13 +122,13 @@ class Sequencer : public RubyPort private: void issueRequest(PacketPtr pkt, RubyRequestType type); - void hitCallback(SequencerRequest* request, + void hitCallback(SequencerRequest* request, GenericMachineType mach, DataBlock& data, bool success, - Time initialRequestTime, - Time forwardRequestTime, - Time firstResponseTime); + Cycles initialRequestTime, + Cycles forwardRequestTime, + Cycles firstResponseTime); RequestStatus insertRequest(PacketPtr pkt, RubyRequestType request_type); @@ -152,10 +152,10 @@ class Sequencer : public RubyPort int m_outstanding_count; bool m_deadlock_check_scheduled; - int m_store_waiting_on_load_cycles; - int m_store_waiting_on_store_cycles; - int m_load_waiting_on_store_cycles; - int m_load_waiting_on_load_cycles; + uint32_t m_store_waiting_on_load_cycles; + uint32_t m_store_waiting_on_store_cycles; + uint32_t m_load_waiting_on_store_cycles; + uint32_t m_load_waiting_on_load_cycles; bool m_usingNetworkTester; diff --git a/src/mem/ruby/system/TBETable.hh b/src/mem/ruby/system/TBETable.hh index fa4493757..018da6cbb 100644 --- a/src/mem/ruby/system/TBETable.hh +++ b/src/mem/ruby/system/TBETable.hh @@ -33,9 +33,6 @@ #include "base/hashmap.hh" #include "mem/ruby/common/Address.hh" -#include "mem/ruby/common/Global.hh" -#include "mem/ruby/profiler/Profiler.hh" -#include "mem/ruby/system/System.hh" template class TBETable diff --git a/src/mem/ruby/system/TimerTable.cc b/src/mem/ruby/system/TimerTable.cc index d87f11662..d29491611 100644 --- a/src/mem/ruby/system/TimerTable.cc +++ b/src/mem/ruby/system/TimerTable.cc @@ -31,13 +31,13 @@ #include "mem/ruby/system/TimerTable.hh" TimerTable::TimerTable() + : m_next_time(0) { m_consumer_ptr = NULL; m_clockobj_ptr = NULL; m_next_valid = false; m_next_address = Address(0); - m_next_time = 0; } bool diff --git a/src/mem/ruby/system/TimerTable.hh b/src/mem/ruby/system/TimerTable.hh index 95af2eaa7..b271d3e37 100644 --- a/src/mem/ruby/system/TimerTable.hh +++ b/src/mem/ruby/system/TimerTable.hh @@ -85,7 +85,7 @@ class TimerTable typedef std::map AddressMap; AddressMap m_map; mutable bool m_next_valid; - mutable Time m_next_time; // Only valid if m_next_valid is true + mutable Cycles m_next_time; // Only valid if m_next_valid is true mutable Address m_next_address; // Only valid if m_next_valid is true //! Object used for querying time. diff --git a/src/mem/slicc/ast/InfixOperatorExprAST.py b/src/mem/slicc/ast/InfixOperatorExprAST.py index 2f62813df..31bf9bd1a 100644 --- a/src/mem/slicc/ast/InfixOperatorExprAST.py +++ b/src/mem/slicc/ast/InfixOperatorExprAST.py @@ -66,7 +66,6 @@ class InfixOperatorExprAST(ExprAST): ("Cycles", "int", "Cycles")] elif self.op in ("+", "-", "*", "/"): expected_types = [("int", "int", "int"), - ("Time", "Time", "Time"), ("Cycles", "Cycles", "Cycles"), ("Cycles", "int", "Cycles"), ("int", "Cycles", "Cycles")] -- 2.30.2