From 25c729bf9f373c6b590ef6647e560f33a954f38b Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Mon, 12 Mar 2012 15:47:06 -0700 Subject: [PATCH] glsl: When failing to compile some builtins, print the error. This makes the process slightly more debuggable, though it would be nice if the build just failed immediately instead. Reviewed-by: Kenneth Graunke --- src/glsl/builtins/tools/generate_builtins.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/glsl/builtins/tools/generate_builtins.py b/src/glsl/builtins/tools/generate_builtins.py index 72d12bb2a9a..9ab6edd226f 100755 --- a/src/glsl/builtins/tools/generate_builtins.py +++ b/src/glsl/builtins/tools/generate_builtins.py @@ -63,6 +63,14 @@ def run_compiler(args): p = Popen(command, 1, stdout=PIPE, shell=False) output = p.communicate()[0] + if (p.returncode): + sys.stderr.write("Failed to compile builtins with command:\n") + for arg in command: + sys.stderr.write(arg + " ") + sys.stderr.write("\n") + sys.stderr.write("Result:\n") + sys.stderr.write(output) + # Clean up output a bit by killing whitespace before a closing paren. kill_paren_whitespace = re.compile(r'[ \n]*\)', re.MULTILINE) output = kill_paren_whitespace.sub(')', output) -- 2.30.2