From 25f194d5acd2bcc031c3e903b8660b9d4821a928 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Sat, 10 Nov 2018 11:41:22 -0800 Subject: [PATCH] iris: more TODO --- src/gallium/drivers/iris/iris_batch.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/iris/iris_batch.c b/src/gallium/drivers/iris/iris_batch.c index 1d3a787d365..bf5300c80fe 100644 --- a/src/gallium/drivers/iris/iris_batch.c +++ b/src/gallium/drivers/iris/iris_batch.c @@ -218,6 +218,9 @@ add_exec_bo(struct iris_batch *batch, struct iris_bo *bo) // XXX: this is bad, we use the same state / instruction buffers for // both batches, and if both of them are reading some dynamic state, // we flush all the time. check for writes vs. reads? + // + // XXX: need to combine add_exec_bo and iris_use_pinned_bo so that + // we know whether we're writing the buffer or not. if (iris_batch_references(batch->other_batches[b], bo)) iris_batch_flush(batch->other_batches[b]); } -- 2.30.2