From 25f91fda52f88f4a639a30ec33d821f1acb9c058 Mon Sep 17 00:00:00 2001 From: Richard Biener Date: Mon, 19 Mar 2018 12:49:30 +0000 Subject: [PATCH] re PR tree-optimization/84929 (ICE at -O3 on valid code on x86_64-linux-gnu: tree check: expected polynomial_chrec, have nop_expr in analyze_siv_subscript_cst_affine, at tree-data-ref.c:3018) 2018-03-19 Richard Biener PR tree-optimization/84929 * tree-data-ref.c (analyze_siv_subscript_cst_affine): Guard chrec_is_positive against non-chrec arg. * gcc.dg/torture/pr84929.c: New testcase. From-SVN: r258643 --- gcc/ChangeLog | 6 ++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/torture/pr84929.c | 10 ++++++++++ gcc/tree-data-ref.c | 6 ++++-- 4 files changed, 25 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/torture/pr84929.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 9e1ccaf8027..b5b55598f81 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2018-03-19 Richard Biener + + PR tree-optimization/84929 + * tree-data-ref.c (analyze_siv_subscript_cst_affine): Guard + chrec_is_positive against non-chrec arg. + 2018-03-19 Tamar Christina PR target/84711 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 865c85117b8..868d8e8f7a6 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-03-19 Richard Biener + + PR tree-optimization/84929 + * gcc.dg/torture/pr84929.c: New testcase. + 2018-03-19 Tamar Christina PR target/84711 diff --git a/gcc/testsuite/gcc.dg/torture/pr84929.c b/gcc/testsuite/gcc.dg/torture/pr84929.c new file mode 100644 index 00000000000..2f46e2943ad --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr84929.c @@ -0,0 +1,10 @@ +/* { dg-do compile } */ +/* { dg-require-effective-target int32plus } */ + +int a[4]; +void fn1() +{ + __UINT64_TYPE__ b = 7818038963515661296; + for (;; b++) + a[0xA699ECD2C348A3A0] = a[b]; +} diff --git a/gcc/tree-data-ref.c b/gcc/tree-data-ref.c index a886329966c..af35e41c745 100644 --- a/gcc/tree-data-ref.c +++ b/gcc/tree-data-ref.c @@ -3015,7 +3015,8 @@ analyze_siv_subscript_cst_affine (tree chrec_a, { if (value0 == false) { - if (!chrec_is_positive (CHREC_RIGHT (chrec_b), &value1)) + if (TREE_CODE (chrec_b) != POLYNOMIAL_CHREC + || !chrec_is_positive (CHREC_RIGHT (chrec_b), &value1)) { if (dump_file && (dump_flags & TDF_DETAILS)) fprintf (dump_file, "siv test failed: chrec not positive.\n"); @@ -3096,7 +3097,8 @@ analyze_siv_subscript_cst_affine (tree chrec_a, } else { - if (!chrec_is_positive (CHREC_RIGHT (chrec_b), &value2)) + if (TREE_CODE (chrec_b) != POLYNOMIAL_CHREC + || !chrec_is_positive (CHREC_RIGHT (chrec_b), &value2)) { if (dump_file && (dump_flags & TDF_DETAILS)) fprintf (dump_file, "siv test failed: chrec not positive.\n"); -- 2.30.2