From 267e265c52284184b5b8ddaa72adc79f9e9db681 Mon Sep 17 00:00:00 2001 From: Paolo Carlini Date: Tue, 27 Jan 2009 19:47:28 +0000 Subject: [PATCH] re PR c++/37554 (ICE with invalid cast) /cp 2009-01-27 Paolo Carlini PR c++/37554 * call.c (build_over_call): If convert_for_arg_passing returns error_mark_node unconditionally return it. /testsuite 2009-01-27 Paolo Carlini PR c++/37554 * g++.dg/parse/crash51.C: New. * g++.old-deja/g++.pt/crash9.C: Adjust. From-SVN: r143711 --- gcc/cp/ChangeLog | 6 ++++++ gcc/cp/call.c | 2 +- gcc/testsuite/ChangeLog | 6 ++++++ gcc/testsuite/g++.dg/parse/crash51.C | 9 +++++++++ gcc/testsuite/g++.old-deja/g++.pt/crash9.C | 6 +++--- 5 files changed, 25 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/g++.dg/parse/crash51.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 876cb7fa6d7..ff63c619a7a 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2009-01-27 Paolo Carlini + + PR c++/37554 + * call.c (build_over_call): If convert_for_arg_passing returns + error_mark_node unconditionally return it. + 2009-01-22 Adam Nemet * class.c (check_field_decls): Also inherit packed for bitfields diff --git a/gcc/cp/call.c b/gcc/cp/call.c index 09dc57d7a25..f13e3bdb8e2 100644 --- a/gcc/cp/call.c +++ b/gcc/cp/call.c @@ -5276,7 +5276,7 @@ build_over_call (struct z_candidate *cand, int flags, tsubst_flags_t complain) (conv, TREE_VALUE (arg), fn, i - is_method, complain); val = convert_for_arg_passing (type, val); - if ((complain == tf_none) && val == error_mark_node) + if (val == error_mark_node) return error_mark_node; else argarray[j++] = val; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index e1c767a7e69..8f1ceb8d2a0 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2009-01-27 Paolo Carlini + + PR c++/37554 + * g++.dg/parse/crash51.C: New. + * g++.old-deja/g++.pt/crash9.C: Adjust. + 2009-01-27 Daniel Kraft PR fortran/38883 diff --git a/gcc/testsuite/g++.dg/parse/crash51.C b/gcc/testsuite/g++.dg/parse/crash51.C new file mode 100644 index 00000000000..03fcd361336 --- /dev/null +++ b/gcc/testsuite/g++.dg/parse/crash51.C @@ -0,0 +1,9 @@ +// PR c++/37554 + +struct A {}; +class B : A {}; + +void foo(B b) +{ + (A)b; // { dg-error "inaccessible base" } +} diff --git a/gcc/testsuite/g++.old-deja/g++.pt/crash9.C b/gcc/testsuite/g++.old-deja/g++.pt/crash9.C index dab0e4c2824..20bd7584fdd 100644 --- a/gcc/testsuite/g++.old-deja/g++.pt/crash9.C +++ b/gcc/testsuite/g++.old-deja/g++.pt/crash9.C @@ -1,11 +1,11 @@ // { dg-do assemble } template -void f(T) {} // { dg-error "" } parameter has incomplete type +void f(T) {} -class C; // { dg-error "" } forward declaration +class C; // { dg-error "forward declaration" } void g(const C& c) { - f(c); // { dg-error "" } invalid use of undefined type + f(c); // { dg-error "invalid use of incomplete type|initializing argument" } } -- 2.30.2