From 2743db69c542d154285c02b6a4747910308d533c Mon Sep 17 00:00:00 2001 From: Eric Botcazou Date: Fri, 26 Feb 2010 23:10:24 +0000 Subject: [PATCH] re PR ada/43096 (miscompilation of ACATS c37105a at -O2) PR ada/43096 * tree-ssa-alias.c (same_type_for_tbaa): Return -1 if the types have the same alias set. From-SVN: r157102 --- gcc/ChangeLog | 6 ++++++ gcc/tree-ssa-alias.c | 16 +++++++++------- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 0825bc4473a..d506a499b74 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2010-02-26 Eric Botcazou + + PR ada/43096 + * tree-ssa-alias.c (same_type_for_tbaa): Return -1 if the types have + the same alias set. + 2010-02-26 H.J. Lu * config.gcc: Set the default arch at least to Prescott for diff --git a/gcc/tree-ssa-alias.c b/gcc/tree-ssa-alias.c index b235eccf08e..73a16375613 100644 --- a/gcc/tree-ssa-alias.c +++ b/gcc/tree-ssa-alias.c @@ -544,13 +544,15 @@ same_type_for_tbaa (tree type1, tree type2) && TREE_CODE (type2) == ARRAY_TYPE) return -1; - /* In Ada, an lvalue of unconstrained type can be used to access an object - of one of its constrained subtypes, for example when a function with an - unconstrained parameter passed by reference is called on a constrained - object and inlined. In this case, the types have the same alias set. */ - if (TYPE_SIZE (type1) && TYPE_SIZE (type2) - && TREE_CONSTANT (TYPE_SIZE (type1)) != TREE_CONSTANT (TYPE_SIZE (type2)) - && get_alias_set (type1) == get_alias_set (type2)) + /* ??? In Ada, an lvalue of an unconstrained type can be used to access an + object of one of its constrained subtypes, e.g. when a function with an + unconstrained parameter passed by reference is called on an object and + inlined. But, even in the case of a fixed size, type and subtypes are + not equivalent enough as to share the same TYPE_CANONICAL, since this + would mean that conversions between them are useless, whereas they are + not (e.g. type and subtypes can have different modes). So, in the end, + they are only guaranteed to have the same alias set. */ + if (get_alias_set (type1) == get_alias_set (type2)) return -1; /* The types are known to be not equal. */ -- 2.30.2