From 27bc8868f245e0ff358804f68a8c3de7e9224fbd Mon Sep 17 00:00:00 2001 From: Peter Korsgaard Date: Sun, 15 Dec 2013 16:17:28 +0100 Subject: [PATCH] pkg-python: improve error handling Make the python packing a bit easier to use by providing a detailed error message if _SETUP_TYPE isn't set to a valid value. At the same time adjust the error message used when _SETUP_TIME isn't set to list the exact variable name that should be set, and don't talk about 'Unknown' as it isn't printed when the variable isn't set (or is set to the empty string). Signed-off-by: Peter Korsgaard --- package/pkg-python.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/package/pkg-python.mk b/package/pkg-python.mk index e436f22aaa..5f137d58f9 100644 --- a/package/pkg-python.mk +++ b/package/pkg-python.mk @@ -94,7 +94,7 @@ ifndef $(2)_SETUP_TYPE ifdef $(3)_SETUP_TYPE $(2)_SETUP_TYPE = $($(3)_SETUP_TYPE) else - $$(error "$(1): Unknown or undefined _SETUP_TYPE") + $$(error "$(2)_SETUP_TYPE must be set") endif endif @@ -124,6 +124,8 @@ $(2)_BASE_BUILD_TGT = build $(2)_BASE_BUILD_OPT = $(2)_BASE_INSTALL_OPT = $$(HOST_PKG_PYTHON_SETUPTOOLS_INSTALL_OPT) endif +else +$$(error "Invalid $(2)_SETUP_TYPE. Valid options are 'distutils' or 'setuptools'") endif # The below statement intends to calculate the dependencies of host -- 2.30.2