From 27d751cdd8809da66ec4f147b1e8ef7582549f34 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Mon, 11 Feb 2019 11:40:38 -0800 Subject: [PATCH] iris: Drop XXX about alpha testing I was misreading i965 - the 3DSTATE_WM::PixelShaderKillsPixel bit from Gen < 8 needed all of this, but the 3DSTATE_PS_EXTRA bit only needs prog_data->uses_kill. --- src/gallium/drivers/iris/iris_state.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gallium/drivers/iris/iris_state.c b/src/gallium/drivers/iris/iris_state.c index 2cf9c62587e..8191141a373 100644 --- a/src/gallium/drivers/iris/iris_state.c +++ b/src/gallium/drivers/iris/iris_state.c @@ -3392,9 +3392,7 @@ iris_store_fs_state(struct iris_context *ice, iris_pack_command(GENX(3DSTATE_PS_EXTRA), psx_state, psx) { psx.PixelShaderValid = true; psx.PixelShaderComputedDepthMode = wm_prog_data->computed_depth_mode; - // XXX: alpha test / alpha to coverage :/ - psx.PixelShaderKillsPixel = wm_prog_data->uses_kill || - wm_prog_data->uses_omask; + psx.PixelShaderKillsPixel = wm_prog_data->uses_kill; psx.AttributeEnable = wm_prog_data->num_varying_inputs != 0; psx.PixelShaderUsesSourceDepth = wm_prog_data->uses_src_depth; psx.PixelShaderUsesSourceW = wm_prog_data->uses_src_w; -- 2.30.2