From 280a87ea694e0d403732ee1a9f30821e777bc5bd Mon Sep 17 00:00:00 2001 From: Sebastien Bourdeauducq Date: Thu, 6 Dec 2012 17:34:48 +0100 Subject: [PATCH] elsewhere: do not create interface in default param --- migen/bus/csr.py | 8 ++++++-- migen/bus/wishbone.py | 12 +++++++++--- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/migen/bus/csr.py b/migen/bus/csr.py index 3200fb5e..0c403fa1 100644 --- a/migen/bus/csr.py +++ b/migen/bus/csr.py @@ -18,8 +18,10 @@ class Interconnect(SimpleInterconnect): pass class Initiator(PureSimulable): - def __init__(self, generator, bus=Interface()): + def __init__(self, generator, bus=None): self.generator = generator + if bus is None: + bus = Interface() self.bus = bus self.transaction = None self.done = False @@ -50,7 +52,7 @@ def _compute_page_bits(nwords): return 0 class SRAM: - def __init__(self, mem_or_size, address, bus=Interface()): + def __init__(self, mem_or_size, address, bus=None): if isinstance(mem_or_size, Memory): assert(mem_or_size.width <= data_width) self.mem = mem_or_size @@ -62,6 +64,8 @@ class SRAM: self._page = RegisterField("page", page_bits) else: self._page = None + if bus is None: + bus = Interface() self.bus = bus def get_registers(self): diff --git a/migen/bus/wishbone.py b/migen/bus/wishbone.py index b1d23233..20f644c1 100644 --- a/migen/bus/wishbone.py +++ b/migen/bus/wishbone.py @@ -133,8 +133,10 @@ class Tap(PureSimulable): self.handler(transaction) class Initiator(PureSimulable): - def __init__(self, generator, bus=Interface()): + def __init__(self, generator, bus=None): self.generator = generator + if bus is None: + bus = Interface() self.bus = bus self.transaction_start = 0 self.transaction = None @@ -178,7 +180,9 @@ class TargetModel: return True class Target(PureSimulable): - def __init__(self, model, bus=Interface()): + def __init__(self, model, bus=None): + if bus is None: + bus = Interface() self.bus = bus self.model = model @@ -195,12 +199,14 @@ class Target(PureSimulable): bus.ack = 0 class SRAM: - def __init__(self, mem_or_size, bus=Interface()): + def __init__(self, mem_or_size, bus=None): if isinstance(mem_or_size, Memory): assert(mem_or_size.width <= 32) self.mem = mem_or_size else: self.mem = Memory(32, mem_or_size//4) + if bus is None: + bus = Interface() self.bus = bus def get_fragment(self): -- 2.30.2