From 28a15f203d778112908633371f7bc6e96bf37fe3 Mon Sep 17 00:00:00 2001 From: Sandipan Das Date: Fri, 12 Jun 2020 19:11:27 +0530 Subject: [PATCH] base: Fix build errors with gcc 10.x This fixes conditions that perform a redundant check to see if an unsigned value is greater than or equal to zero. With gcc 10.x, this generates the following error because of implicit usage of the "-Werror=type-limits" flag. "comparison of unsigned expression in '>= 0' is always true" Change-Id: Ib1a88035ef5fba410d18de0adf614db4bc634faf Signed-off-by: Sandipan Das Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30474 Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power Tested-by: kokoro --- src/base/statistics.hh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/base/statistics.hh b/src/base/statistics.hh index 8f665fe0e..ee541fbc8 100644 --- a/src/base/statistics.hh +++ b/src/base/statistics.hh @@ -1161,7 +1161,7 @@ class VectorBase : public DataWrapVec Proxy operator[](off_type index) { - assert (index >= 0 && index < size()); + assert (index < size()); return Proxy(this->self(), index); } }; @@ -1235,7 +1235,7 @@ class VectorProxy ScalarProxy operator[](off_type index) { - assert (index >= 0 && index < size()); + assert (index < size()); return ScalarProxy(stat, offset + index); } @@ -1311,7 +1311,7 @@ class Vector2dBase : public DataWrapVec2d operator[](off_type index) { off_type offset = index * y; - assert (index >= 0 && offset + y <= size()); + assert (offset + y <= size()); return Proxy(this->self(), offset, y); } @@ -1995,7 +1995,7 @@ class VectorDistBase : public DataWrapVec Proxy operator[](off_type index) { - assert(index >= 0 && index < size()); + assert(index < size()); return Proxy(this->self(), index); } -- 2.30.2