From 28c84b6247e1ff5f3c7aa4c4912c361012fa3904 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Thu, 31 May 2018 21:49:54 +0200 Subject: [PATCH] re PR target/85984 (ICE in create_pseudo_cfg, at dwarf2cfi.c:2874) PR target/85984 * bb-reorder.c (pass_partition_blocks::gate): Return false for functions with naked attribute. * gcc.target/i386/pr85984.c: New test. From-SVN: r261037 --- gcc/ChangeLog | 6 ++++++ gcc/bb-reorder.c | 5 +++-- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.target/i386/pr85984.c | 18 ++++++++++++++++++ 4 files changed, 32 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr85984.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index a4563e00b8f..09c8b7cdd94 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2018-05-31 Jakub Jelinek + + PR target/85984 + * bb-reorder.c (pass_partition_blocks::gate): Return false for + functions with naked attribute. + 2018-05-31 Uros Bizjak * config/i386/sse.md (avx_vec_concat): diff --git a/gcc/bb-reorder.c b/gcc/bb-reorder.c index 6f2ad5a5220..d1019d01d09 100644 --- a/gcc/bb-reorder.c +++ b/gcc/bb-reorder.c @@ -2928,8 +2928,8 @@ pass_partition_blocks::gate (function *fun) { /* The optimization to partition hot/cold basic blocks into separate sections of the .o file does not work well with linkonce or with - user defined section attributes. Don't call it if either case - arises. */ + user defined section attributes or with naked attribute. Don't call + it if either case arises. */ return (flag_reorder_blocks_and_partition && optimize /* See pass_reorder_blocks::gate. We should not partition if @@ -2937,6 +2937,7 @@ pass_partition_blocks::gate (function *fun) && optimize_function_for_speed_p (fun) && !DECL_COMDAT_GROUP (current_function_decl) && !lookup_attribute ("section", DECL_ATTRIBUTES (fun->decl)) + && !lookup_attribute ("naked", DECL_ATTRIBUTES (fun->decl)) /* Workaround a bug in GDB where read_partial_die doesn't cope with DIEs with DW_AT_ranges, see PR81115. */ && !(in_lto_p && MAIN_NAME_P (DECL_NAME (fun->decl)))); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index b414492dfb2..e0745e08fc8 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-05-31 Jakub Jelinek + + PR target/85984 + * gcc.target/i386/pr85984.c: New test. + 2018-05-31 Martin Sebor PR c/82063 diff --git a/gcc/testsuite/gcc.target/i386/pr85984.c b/gcc/testsuite/gcc.target/i386/pr85984.c new file mode 100644 index 00000000000..23dd53dc2cf --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr85984.c @@ -0,0 +1,18 @@ +/* PR target/85984 */ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +int foo (void); + +void __attribute__((naked)) +bar (void) +{ + if (!foo ()) + __builtin_abort (); +} + +void +baz (void) +{ + bar (); +} -- 2.30.2