From 28cebdb178ecfad17726711c78e1aa669cb5393c Mon Sep 17 00:00:00 2001 From: Richard Sandiford Date: Wed, 20 Nov 2019 21:13:05 +0000 Subject: [PATCH] Restrict bb-slp-40.c to targets with VnQI addition (PR 92366) bb-slp-40.c fails on SPARC targets without VIS4 because it requires addition on vectors of bytes. There doesn't seem to be an existing target selector for this, so I added vect_char_add. (Wasn't sure whether to use vect_char_add, for consistency with vect_no_int_add/vect_int_mult etc., or vect_add_char for consistency with vect_shift_char etc.) I took the target list from vect_int and removed targets that didn't seem to support the operation (namely sparc*, since we don't seem to have any test for VIS4, niagara7 or m8, and alpha*-*-*.) 2019-11-20 Richard Sandiford gcc/ PR testsuite/92366 * doc/sourcebuild.texi (vect_char_add): Document. gcc/testsuite/ PR testsuite/92366 * lib/target-supports.exp (check_effective_target_vect_char_add): New proc. * gcc.dg/vect/bb-slp-40.c: Require vect_char_add instead of vect_int. From-SVN: r278532 --- gcc/ChangeLog | 5 +++++ gcc/doc/sourcebuild.texi | 4 ++++ gcc/testsuite/ChangeLog | 7 +++++++ gcc/testsuite/gcc.dg/vect/bb-slp-40.c | 2 +- gcc/testsuite/lib/target-supports.exp | 21 +++++++++++++++++++++ 5 files changed, 38 insertions(+), 1 deletion(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 31a270ab9a0..3ddaa8a059d 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2019-11-20 Richard Sandiford + + PR testsuite/92366 + * doc/sourcebuild.texi (vect_char_add): Document. + 2019-11-20 Alexandre Oliva * function.h (CALLEE_FROM_CGRAPH_P): Remove. diff --git a/gcc/doc/sourcebuild.texi b/gcc/doc/sourcebuild.texi index 5fbe876e31b..a30db0de88f 100644 --- a/gcc/doc/sourcebuild.texi +++ b/gcc/doc/sourcebuild.texi @@ -1522,6 +1522,10 @@ Target does not support a vector add instruction on @code{int}. @item vect_no_bitwise Target does not support vector bitwise instructions. +@item vect_char_add +Target supports addition of @code{char} vectors for at least one +vector length. + @item vect_char_mult Target supports @code{vector char} multiplication. diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 4dcb96763c6..99949be253c 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2019-11-20 Richard Sandiford + + PR testsuite/92366 + * lib/target-supports.exp (check_effective_target_vect_char_add): + New proc. + * gcc.dg/vect/bb-slp-40.c: Require vect_char_add instead of vect_int. + 2019-11-20 Richard Sandiford PR testsuite/92527 diff --git a/gcc/testsuite/gcc.dg/vect/bb-slp-40.c b/gcc/testsuite/gcc.dg/vect/bb-slp-40.c index ce5a75c979c..66fb4e07f80 100644 --- a/gcc/testsuite/gcc.dg/vect/bb-slp-40.c +++ b/gcc/testsuite/gcc.dg/vect/bb-slp-40.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-additional-options "-fvect-cost-model=dynamic" } */ -/* { dg-require-effective-target vect_int } */ +/* { dg-require-effective-target vect_char_add } */ char g_d[1024], g_s1[1024], g_s2[1024]; void foo(void) diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 08af9f85b4e..5fe1e83492c 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -5749,6 +5749,27 @@ proc check_effective_target_vect_bswap { } { || [istarget amdgcn-*-*] }}] } +# Return 1 if the target supports addition of char vectors for at least +# one vector length. + +proc check_effective_target_vect_char_add { } { + return [check_cached_effective_target_indexed vect_int { + expr { + [istarget i?86-*-*] || [istarget x86_64-*-*] + || ([istarget powerpc*-*-*] + && ![istarget powerpc-*-linux*paired*]) + || [istarget amdgcn-*-*] + || [istarget ia64-*-*] + || [istarget aarch64*-*-*] + || [is-effective-target arm_neon] + || ([istarget mips*-*-*] + && ([et-is-effective-target mips_loongson_mmi] + || [et-is-effective-target mips_msa])) + || ([istarget s390*-*-*] + && [check_effective_target_s390_vx]) + }}] +} + # Return 1 if the target supports hardware vector shift operation for char. proc check_effective_target_vect_shift_char { } { -- 2.30.2