From 28e0e05badfbdf7930bbd6f3051b07dd7ec37ae2 Mon Sep 17 00:00:00 2001 From: Richard Biener Date: Fri, 26 May 2017 07:19:00 +0000 Subject: [PATCH] re PR tree-optimization/80842 (ICE at -O3 on x86_64-linux-gnu in "set_lattice_value") 2017-05-26 Richard Biener PR tree-optimization/80842 * tree-ssa-ccp.c (set_lattice_value): Always meet with the old value. * gcc.dg/torture/pr80842.c: New testcase. From-SVN: r248482 --- gcc/ChangeLog | 6 ++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/torture/pr80842.c | 23 +++++++++++++++++++++++ gcc/tree-ssa-ccp.c | 4 +--- 4 files changed, 35 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/torture/pr80842.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 3505ba0576a..f281611171a 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2017-05-26 Richard Biener + + PR tree-optimization/80842 + * tree-ssa-ccp.c (set_lattice_value): Always meet with the old + value. + 2017-05-26 Richard Biener PR tree-optimization/80844 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 0adf5cb7b21..6042b1902ef 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2017-05-26 Richard Biener + + PR tree-optimization/80842 + * gcc.dg/torture/pr80842.c: New testcase. + 2017-05-25 Paolo Carlini PR c++/79652 diff --git a/gcc/testsuite/gcc.dg/torture/pr80842.c b/gcc/testsuite/gcc.dg/torture/pr80842.c new file mode 100644 index 00000000000..600e8ce13ae --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr80842.c @@ -0,0 +1,23 @@ +/* { dg-do compile } */ + +unsigned a; +short b; +char c, d, e; +void fn1(); +void fn2() { + a++; + for (; a;) + fn1(0, 0); +} +void fn3() { + fn2(); +l1:; + unsigned char f; + short g; + unsigned char *h = &f; + g += &h ? e ? g = 1 : 0 : 0; + d = g; + c *f; + if (d & (b %= *h) < f * d / (d -= 0)) + goto l1; +} diff --git a/gcc/tree-ssa-ccp.c b/gcc/tree-ssa-ccp.c index b54062c9cea..f18f2e0c2a4 100644 --- a/gcc/tree-ssa-ccp.c +++ b/gcc/tree-ssa-ccp.c @@ -497,9 +497,7 @@ set_lattice_value (tree var, ccp_prop_value_t *new_val) use the meet operator to retain a conservative value. Missed optimizations like PR65851 makes this necessary. It also ensures we converge to a stable lattice solution. */ - if (new_val->lattice_val == CONSTANT - && old_val->lattice_val == CONSTANT - && TREE_CODE (new_val->value) != SSA_NAME) + if (old_val->lattice_val != UNINITIALIZED) ccp_lattice_meet (new_val, old_val); gcc_checking_assert (valid_lattice_transition (*old_val, *new_val)); -- 2.30.2