From 29928b8e3b79e14abb11cfa78daec447158b79d4 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Mon, 28 Feb 2022 10:53:13 -0700 Subject: [PATCH] Fix maybe-uninitialized warning in py-infthread.c MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit I got this warning from py-infthread.c using the Fedora 34 system GCC: ../../binutils-gdb/gdb/python/py-infthread.c:102:30: warning: ‘extra_info’ may be used uninitialized in this function [-Wmaybe-uninitialized] I think this happens because GDB_PY_HANDLE_EXCEPTION expands to an 'if' whose condition is always true -- but GCC can't know this. This patch avoids the warning by adding a harmless initialization. --- gdb/python/py-infthread.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gdb/python/py-infthread.c b/gdb/python/py-infthread.c index 66c3efdf6cc..c94d5b0ddab 100644 --- a/gdb/python/py-infthread.c +++ b/gdb/python/py-infthread.c @@ -87,7 +87,9 @@ thpy_get_details (PyObject *self, void *ignore) THPY_REQUIRE_VALID (thread_obj); - const char *extra_info; + /* GCC can't tell that extra_info will always be assigned after the + 'catch', so initialize it. */ + const char *extra_info = nullptr; try { extra_info = target_extra_thread_info (thread_obj->thread); -- 2.30.2