From 29a7631986b10c99d5daad1a571716086a325bd5 Mon Sep 17 00:00:00 2001 From: Dave Airlie Date: Fri, 5 Oct 2018 09:56:19 +1000 Subject: [PATCH] anv: add missing unlock in error path. Not going to matter, but be consistent. Found by coverity Reviewed-by: Lionel Landwerlin Reviewed-by: Jason Ekstrand Fixes: caf41c78c (anv/allocator: Support softpin in the BO cache) --- src/intel/vulkan/anv_allocator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_allocator.c b/src/intel/vulkan/anv_allocator.c index f62d48ae3fe..67f2f73aa11 100644 --- a/src/intel/vulkan/anv_allocator.c +++ b/src/intel/vulkan/anv_allocator.c @@ -1358,6 +1358,7 @@ anv_bo_cache_import(struct anv_device *device, if ((new_flags & EXEC_OBJECT_PINNED) && (bo->bo.flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) != (bo_flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS)) { + pthread_mutex_unlock(&cache->mutex); return vk_errorf(device->instance, NULL, VK_ERROR_INVALID_EXTERNAL_HANDLE, "The same BO was imported on two different heaps"); -- 2.30.2