From 29e4b949b45b468c366b9865298391c89ba6642c Mon Sep 17 00:00:00 2001 From: Ian Romanick Date: Mon, 17 Dec 2018 18:48:17 -0800 Subject: [PATCH] Revert "nir/lower_indirect: Bail early if modes == 0" "There's no point in walking the program if we're never going to actually lower anything." Except we might lower compacted local arrays. In that case, modes will be 0, but there is still lowering to be done. This reverts commit 7f75cf2a9408b9af562e033ef6c1d1fd15141421. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109081 Suggested-by: Kenneth Graunke Reviewed-by: Jason Ekstrand Reviewed-by: Lionel Landwerlin Tested-by: Clayton Craft Cc: Kenneth Graunke --- src/compiler/nir/nir_lower_indirect_derefs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/compiler/nir/nir_lower_indirect_derefs.c b/src/compiler/nir/nir_lower_indirect_derefs.c index adcfaec219f..cf025bb0425 100644 --- a/src/compiler/nir/nir_lower_indirect_derefs.c +++ b/src/compiler/nir/nir_lower_indirect_derefs.c @@ -205,9 +205,6 @@ nir_lower_indirect_derefs(nir_shader *shader, nir_variable_mode modes) { bool progress = false; - if (modes == 0) - return false; - nir_foreach_function(function, shader) { if (function->impl) progress = lower_indirects_impl(function->impl, modes) || progress; -- 2.30.2