From 2a58c80212892d88e199e6ab154404b80fdbd298 Mon Sep 17 00:00:00 2001 From: Richard Biener Date: Mon, 12 Jan 2015 15:34:37 +0000 Subject: [PATCH] re PR tree-optimization/64357 (ICE at -Os on x86_64-linux-gnu in check_loop_closed_ssa_use, at tree-ssa-loop-manip.c:579) 2015-01-12 Richard Biener PR middle-end/64357 * tree-cfg.c (gimple_can_merge_blocks_p): Protect simple latches properly. * gcc.dg/torture/pr64357.c: New testcase. From-SVN: r219473 --- gcc/ChangeLog | 6 +++++ gcc/testsuite/ChangeLog | 5 ++++ gcc/testsuite/gcc.dg/torture/pr64357.c | 34 ++++++++++++++++++++++++++ gcc/tree-cfg.c | 6 +++-- 4 files changed, 49 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/torture/pr64357.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c757e0b175a..dfba0bc433c 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2015-01-12 Richard Biener + + PR middle-end/64357 + * tree-cfg.c (gimple_can_merge_blocks_p): Protect simple + latches properly. + 2015-01-12 Kyrylo Tkachov * config/arm/arm.c (arm_cortex_a12_tune): Update entries to match diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 6ff63449c80..3cda6b359a6 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-01-12 Richard Biener + + PR middle-end/64357 + * gcc.dg/torture/pr64357.c: New testcase. + 2015-01-12 H.J. Lu * gcc.target/i386/nop-mcount.c: Properly place {} in target diff --git a/gcc/testsuite/gcc.dg/torture/pr64357.c b/gcc/testsuite/gcc.dg/torture/pr64357.c new file mode 100644 index 00000000000..ff966efeeae --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr64357.c @@ -0,0 +1,34 @@ +/* { dg-do compile } */ + +int a, b, c, d, e, f; + +long long +fn1 (int p) +{ + return p ? p : 1; +} + +static int +fn2 () +{ +lbl: + for (; f;) + return 0; + for (;;) + { + for (b = 0; b; ++b) + if (d) + goto lbl; + c = e; + } +} + +void +fn3 () +{ + for (; a; a = fn1 (a)) + { + fn2 (); + e = 0; + } +} diff --git a/gcc/tree-cfg.c b/gcc/tree-cfg.c index a9a2c2f7392..38e5e7db432 100644 --- a/gcc/tree-cfg.c +++ b/gcc/tree-cfg.c @@ -1723,11 +1723,13 @@ gimple_can_merge_blocks_p (basic_block a, basic_block b) } /* Protect simple loop latches. We only want to avoid merging - the latch with the loop header in this case. */ + the latch with the loop header or with a block in another + loop in this case. */ if (current_loops && b->loop_father->latch == b && loops_state_satisfies_p (LOOPS_HAVE_SIMPLE_LATCHES) - && b->loop_father->header == a) + && (b->loop_father->header == a + || b->loop_father != a->loop_father)) return false; /* It must be possible to eliminate all phi nodes in B. If ssa form -- 2.30.2