From 2abc6299bfa29d905046c7d198e3262fb19c0119 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Samuel=20Iglesias=20Gons=C3=A1lvez?= Date: Tue, 10 Jul 2018 12:04:38 +0200 Subject: [PATCH] nir: fix denorm flush-to-zero in sqrt's lowering at nir_lower_double_ops MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit v2: - Replace hard coded value with DBL_MIN (Connor). v3: - Have into account the FLOAT_CONTROLS_DENORM_PRESERVE_FP64 flag (Caio). Signed-off-by: Samuel Iglesias Gonsálvez Signed-off-by: Andres Gomez Reviewed-by: Connor Abbott [v2] --- src/compiler/nir/nir_lower_double_ops.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_lower_double_ops.c b/src/compiler/nir/nir_lower_double_ops.c index 45ac155de51..322ae49bacd 100644 --- a/src/compiler/nir/nir_lower_double_ops.c +++ b/src/compiler/nir/nir_lower_double_ops.c @@ -26,6 +26,8 @@ #include "nir_builder.h" #include "c99_math.h" +#include + /* * Lowers some unsupported double operations, using only: * @@ -289,9 +291,20 @@ lower_sqrt_rsq(nir_builder *b, nir_ssa_def *src, bool sqrt) * 0 -> 0 and * +inf -> +inf */ - res = nir_bcsel(b, nir_ior(b, nir_feq(b, src, nir_imm_double(b, 0.0)), + const bool preserve_denorms = + b->shader->info.float_controls_execution_mode & + FLOAT_CONTROLS_DENORM_PRESERVE_FP64; + nir_ssa_def *src_flushed = src; + if (!preserve_denorms) { + src_flushed = nir_bcsel(b, + nir_flt(b, nir_fabs(b, src), + nir_imm_double(b, DBL_MIN)), + nir_imm_double(b, 0.0), + src); + } + res = nir_bcsel(b, nir_ior(b, nir_feq(b, src_flushed, nir_imm_double(b, 0.0)), nir_feq(b, src, nir_imm_double(b, INFINITY))), - src, res); + src_flushed, res); } else { res = fix_inv_result(b, res, src, new_exp); } -- 2.30.2