From 2aece9c19970ad94abeeca4f85782f50799abdfc Mon Sep 17 00:00:00 2001 From: Jeff Law Date: Wed, 23 May 2018 16:33:36 -0600 Subject: [PATCH] re PR target/78849 (ICE on initialization of global struct containing __int20 array at varasm.c:4968) PR target/78849 * gcc/tree.c (build_common_tree_nodes): Dont set TYPE_SIZE for __intN types. PR target/78849 * gcc.target/msp430/msp430.exp: Remove -pedantic-errors from DEFAULT_CFLAGS. * gcc.target/msp430/pr78849.c: New test. From-SVN: r260627 --- gcc/ChangeLog | 8 +++- gcc/testsuite/ChangeLog | 7 +++ gcc/testsuite/gcc.target/msp430/msp430.exp | 13 ++++-- gcc/testsuite/gcc.target/msp430/pr78849.c | 50 ++++++++++++++++++++++ gcc/tree.c | 2 - 5 files changed, 73 insertions(+), 7 deletions(-) create mode 100644 gcc/testsuite/gcc.target/msp430/pr78849.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 555a0f7ac00..df282da3615 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,4 +1,10 @@ -2017-05-23 Segher Boessenkool +2018-05-23 Jozef Lawrynowicz + + PR target/78849 + * gcc/tree.c (build_common_tree_nodes): Dont set TYPE_SIZE for __intN + types. + +2018-05-23 Segher Boessenkool * doc/sourcebuild.texi (Endianness): New subsubsection. diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 01bc8b1c9b4..fb4c74e0244 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2018-05-23 Jozef Lawrynowicz + + PR target/78849 + * gcc.target/msp430/msp430.exp: Remove -pedantic-errors from + DEFAULT_CFLAGS. + * gcc.target/msp430/pr78849.c: New test. + 2018-05-23 Marek Polacek * g++.dg/cpp2a/range-for8.C: New test. diff --git a/gcc/testsuite/gcc.target/msp430/msp430.exp b/gcc/testsuite/gcc.target/msp430/msp430.exp index f34205b95ec..0bd42c24f2b 100644 --- a/gcc/testsuite/gcc.target/msp430/msp430.exp +++ b/gcc/testsuite/gcc.target/msp430/msp430.exp @@ -24,10 +24,15 @@ if { ![istarget msp430-*-*] } then { # Load support procs. load_lib gcc-dg.exp -# If a testcase doesn't have special options, use these. +# The '-pedantic-errors' option in the global variable DEFAULT_CFLAGS that is +# set by other drivers causes an error when the __int20 type is used, so remove +# this option from DEFAULT_CFLAGS for the msp430 tests. global DEFAULT_CFLAGS -if ![info exists DEFAULT_CFLAGS] then { - set DEFAULT_CFLAGS "" +if [info exists DEFAULT_CFLAGS] then { + set MSP430_DEFAULT_CFLAGS \ + [ string map { "-pedantic-errors" "" } $DEFAULT_CFLAGS ] +} else { + set MSP430_DEFAULT_CFLAGS "" } # Initialize `dg'. @@ -35,7 +40,7 @@ dg-init # Main loop. dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cCS\]]] \ - "" $DEFAULT_CFLAGS + "" $MSP430_DEFAULT_CFLAGS # All done. dg-finish diff --git a/gcc/testsuite/gcc.target/msp430/pr78849.c b/gcc/testsuite/gcc.target/msp430/pr78849.c new file mode 100644 index 00000000000..f70f0bbf5f7 --- /dev/null +++ b/gcc/testsuite/gcc.target/msp430/pr78849.c @@ -0,0 +1,50 @@ +/* { dg-do compile } */ +/* { dg-final { scan-assembler ".size.*instance.*52" } } */ + +struct t_inner +{ + __int20 a; + char val1; + __int20 b[3]; + char val2; +}; + +struct t_full +{ + __int20 array[2]; + char val1; + struct t_inner bb[2]; + char val2; +}; + +struct t_full instance = +{ + { + 4231, + 3212, + }, + 5, + { + { + 87680, + 20, + { + 2534, + 3, + 41, + }, + 55, + }, + { + 567, + 4, + { + 43522, + 5433, + 454, + }, + 88, + }, + }, + 8, +}; diff --git a/gcc/tree.c b/gcc/tree.c index ff982fe43f8..e8dc42557d0 100644 --- a/gcc/tree.c +++ b/gcc/tree.c @@ -9785,8 +9785,6 @@ build_common_tree_nodes (bool signed_char) { int_n_trees[i].signed_type = make_signed_type (int_n_data[i].bitsize); int_n_trees[i].unsigned_type = make_unsigned_type (int_n_data[i].bitsize); - TYPE_SIZE (int_n_trees[i].signed_type) = bitsize_int (int_n_data[i].bitsize); - TYPE_SIZE (int_n_trees[i].unsigned_type) = bitsize_int (int_n_data[i].bitsize); if (int_n_data[i].bitsize > LONG_LONG_TYPE_SIZE && int_n_enabled_p[i]) -- 2.30.2