From 2b69941d0d6730f1968c41bee216d46de48b4839 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Mon, 25 Nov 2013 08:47:51 -0700 Subject: [PATCH] fix a couple of FIXMEs This fixes a couple of old "32x64" FIXME comments by using paddress with current_gdbarch rather than hex_string and a cast to long. 2013-12-06 Tom Tromey * cli/cli-cmds.c (edit_command): Use paddress, not hex_string. (list_command): Likewise. --- gdb/ChangeLog | 5 +++++ gdb/cli/cli-cmds.c | 6 ++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 38ba081a7e2..fc35c227466 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2013-12-06 Tom Tromey + + * cli/cli-cmds.c (edit_command): Use paddress, not hex_string. + (list_command): Likewise. + 2013-12-06 Tom Tromey * psymtab.c (allocate_psymtab): Put the filename in the filename diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index 85f171356c4..52a6bc90a78 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -817,9 +817,8 @@ edit_command (char *arg, int from_tty) struct gdbarch *gdbarch; if (sal.symtab == 0) - /* FIXME-32x64--assumes sal.pc fits in long. */ error (_("No source file for address %s."), - hex_string ((unsigned long) sal.pc)); + paddress (get_current_arch (), sal.pc)); gdbarch = get_objfile_arch (sal.symtab->objfile); sym = find_pc_function (sal.pc); @@ -982,9 +981,8 @@ list_command (char *arg, int from_tty) struct gdbarch *gdbarch; if (sal.symtab == 0) - /* FIXME-32x64--assumes sal.pc fits in long. */ error (_("No source file for address %s."), - hex_string ((unsigned long) sal.pc)); + paddress (get_current_arch (), sal.pc)); gdbarch = get_objfile_arch (sal.symtab->objfile); sym = find_pc_function (sal.pc); -- 2.30.2