From 2c6a7fbeb78856d6405e1c0dff17a58478b0019e Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Sat, 16 Feb 2019 01:04:07 +0000 Subject: [PATCH] panfrost: Fix clipping region Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c index cfed9f6ff90..822b5a0dfef 100644 --- a/src/gallium/drivers/panfrost/pan_context.c +++ b/src/gallium/drivers/panfrost/pan_context.c @@ -557,10 +557,17 @@ panfrost_viewport(struct panfrost_context *ctx, * (somewhat) asymmetric ints. */ struct mali_viewport ret = { - .clip_minx = viewport_x0, - .clip_miny = viewport_y0, - .clip_maxx = viewport_x1, - .clip_maxy = viewport_x1, + /* By default, do no viewport clipping, i.e. clip to (-inf, + * inf) in each direction. Clipping to the viewport in theory + * should work, but in practice causes issues when we're not + * explicitly trying to scissor */ + + .clip_minx = -inff, + .clip_miny = -inff, + .clip_maxx = inff, + .clip_maxy = inff, + + /* We always perform depth clipping (TODO: Can this be disabled?) */ .clip_minz = depth_clip_near, .clip_maxz = depth_clip_far, -- 2.30.2