From 2ce11ac11fee594ca01608c4006b38c0c8ea37ff Mon Sep 17 00:00:00 2001 From: Bas Nieuwenhuizen Date: Thu, 11 Jan 2018 13:21:50 +0100 Subject: [PATCH] radv: Initialize DCC on transition from preinitialized. Looks like the decompress does not handle invalid encodings well, which happens with random memory. Of course apps should not use it with random memory, but they are allowed to .... Fixes: 44fcf58744 "radv: Disable DCC for GENERAL layout and compute transfer dest." Reviewed-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 67799a13cc2..172f95e7c99 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -4026,7 +4026,9 @@ static void radv_handle_dcc_image_transition(struct radv_cmd_buffer *cmd_buffer, unsigned dst_queue_mask, const VkImageSubresourceRange *range) { - if (src_layout == VK_IMAGE_LAYOUT_UNDEFINED) { + if (src_layout == VK_IMAGE_LAYOUT_PREINITIALIZED) { + radv_initialize_dcc(cmd_buffer, image, 0xffffffffu); + } else if (src_layout == VK_IMAGE_LAYOUT_UNDEFINED) { radv_initialize_dcc(cmd_buffer, image, radv_layout_dcc_compressed(image, dst_layout, dst_queue_mask) ? 0x20202020u : 0xffffffffu); -- 2.30.2